From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zeniv.linux.org.uk ([195.92.253.2]:52808 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725749AbeLAIfm (ORCPT ); Sat, 1 Dec 2018 03:35:42 -0500 Date: Fri, 30 Nov 2018 21:25:03 +0000 From: Al Viro To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, hch@lst.de Subject: Re: [PATCH 24/27] block: implement bio helper to add iter kvec pages to bio Message-ID: <20181130212503.GS2217@ZenIV.linux.org.uk> References: <20181130165646.27341-1-axboe@kernel.dk> <20181130165646.27341-25-axboe@kernel.dk> <20181130192102.GP2217@ZenIV.linux.org.uk> <6e42d763-9c94-6b84-7099-f5ef5964404c@kernel.dk> <1545b364-df01-51e7-1786-56dde7c49b5d@kernel.dk> <20181130211117.GQ2217@ZenIV.linux.org.uk> <07803d69-84cc-bb39-686f-2f50874ea184@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <07803d69-84cc-bb39-686f-2f50874ea184@kernel.dk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Nov 30, 2018 at 02:16:38PM -0700, Jens Axboe wrote: > >> Would this make you happy: > >> > >> if (!is_vmalloc_addr(kv->iov_base)) > >> page = virt_to_page(kv->iov_base); > >> else > >> page = vmalloc_to_page(kv->iov_base); > > > > Free advice: don't ever let Linus see anything along those lines. Results > > tend to be colourful... > > We already have those lines in the kernel, XFS for instance. Al, could you > please try to be helpful instead of being deliberately obtuse? Again, the last time something like that had been suggested, Linus had replied with a very impressive rant. I *did* propose pretty much that, and reaction was basically "hell no, not in general-purpose primitives". Precisely about iov_iter stuff. A part of that was due to touching page refcounts, but quite a bit wasn't.