From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.133]:49070 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725745AbeLBIbc (ORCPT ); Sun, 2 Dec 2018 03:31:32 -0500 Date: Sat, 1 Dec 2018 13:18:06 -0800 From: Matthew Wilcox To: Olga Kornievskaia Cc: bfields@redhat.com, linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 01/10] VFS generic copy_file_range() support Message-ID: <20181201211806.GO10377@bombadil.infradead.org> References: <20181130200348.59524-1-olga.kornievskaia@gmail.com> <20181130200348.59524-2-olga.kornievskaia@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181130200348.59524-2-olga.kornievskaia@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Nov 30, 2018 at 03:03:39PM -0500, Olga Kornievskaia wrote: > Relax the condition that input files must be from the same > file systems. > + ret = do_splice_direct(file_in, &pos_in, file_out, &pos_out, > + count > MAX_RW_COUNT ? MAX_RW_COUNT : count, 0); Wasn't there a concern about splicing between filesystems with different block sizes mentioned the last time this came up? I can't find a citation for that now. > - /* this could be relaxed once generic cross fs support is added */ > - if (inode_in->i_sb != inode_out->i_sb) { > - ret = -EXDEV; > - goto done; > - }