From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Dave Chinner <david@fromorbit.com>,
xfs <linux-xfs@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
amir73il@gmail.com, linux-unionfs@vger.kernel.org
Subject: Re: [PATCH] vfs: allow remap flags to be passed to vfs_clone_file_range
Date: Sun, 2 Dec 2018 07:59:06 -0800 [thread overview]
Message-ID: <20181202155906.GA15501@infradead.org> (raw)
In-Reply-To: <20181130204238.GE8131@magnolia>
On Fri, Nov 30, 2018 at 12:42:38PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> In overlayfs, ovl_remap_file_range calls vfs_clone_file_range on the
> lower filesystem's inode, passing through whatever remap flags it got
> from its caller. Since vfs_copy_file_range first tries a filesystem's
> remap function with REMAP_FILE_CAN_SHORTEN, this can get passed through
> to the second vfs_copy_file_range call, which isn't an issue.
> Remove the WARN_ON because it's unnecessary.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
This looks ok:
Reviewed-by: Christoph Hellwig <hch@lst.de>
But this also indicates that do_clone_file_range/vfs_clone_file_range
are misnamed now, as they are wrappers for the remap_file_range method.
prev parent reply other threads:[~2018-12-02 15:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 20:42 [PATCH] vfs: allow remap flags to be passed to vfs_clone_file_range Darrick J. Wong
2018-12-01 9:37 ` Amir Goldstein
2018-12-02 1:07 ` [PATCH v2] vfs: allow some " Darrick J. Wong
2018-12-02 15:59 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181202155906.GA15501@infradead.org \
--to=hch@infradead.org \
--cc=amir73il@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).