From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:44200 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726064AbeLDOtW (ORCPT ); Tue, 4 Dec 2018 09:49:22 -0500 Date: Tue, 4 Dec 2018 15:49:21 +0100 From: Christoph Hellwig To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, hch@lst.de Subject: Re: [PATCH 10/27] aio: don't zero entire aio_kiocb aio_get_req() Message-ID: <20181204144921.GE3180@lst.de> References: <20181130165646.27341-1-axboe@kernel.dk> <20181130165646.27341-11-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181130165646.27341-11-axboe@kernel.dk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: > - req = kmem_cache_alloc(kiocb_cachep, GFP_KERNEL|__GFP_ZERO); > - if (unlikely(!req)) > - return NULL; > + req = kmem_cache_alloc(kiocb_cachep, GFP_KERNEL); > + if (req) { > + percpu_ref_get(&ctx->reqs); > + req->ki_ctx = ctx; > + INIT_LIST_HEAD(&req->ki_list); > + refcount_set(&req->ki_refcnt, 0); > + req->ki_eventfd = NULL; > + } > > - percpu_ref_get(&ctx->reqs); > - INIT_LIST_HEAD(&req->ki_list); > - refcount_set(&req->ki_refcnt, 0); > - req->ki_ctx = ctx; > return req; Why the reformatting? Otherwise this looks fine to me: Reviewed-by: Christoph Hellwig