From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ipmail03.adl6.internode.on.net ([150.101.137.143]:31496 "EHLO ipmail03.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727575AbeLEVIa (ORCPT ); Wed, 5 Dec 2018 16:08:30 -0500 Date: Thu, 6 Dec 2018 08:08:24 +1100 From: Dave Chinner To: Christoph Hellwig Cc: Amir Goldstein , linux-fsdevel , linux-xfs , Olga Kornievskaia , Linux NFS Mailing List , overlayfs , ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org Subject: Re: [PATCH 01/11] vfs: copy_file_range source range over EOF should fail Message-ID: <20181205210824.GT6311@dastard> References: <20181203083416.28978-1-david@fromorbit.com> <20181203083416.28978-2-david@fromorbit.com> <20181204151332.GA32245@infradead.org> <20181204212948.GO6311@dastard> <20181205141252.GB21109@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181205141252.GB21109@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Dec 05, 2018 at 06:12:52AM -0800, Christoph Hellwig wrote: > > Realistically, though, I think an attempt to read beyond EOF for the > > copy should result in behaviour like read() (i.e. return 0 bytes), > > not EINVAL. The existing behaviour needs to change, though. > > I agree with this statement. So we don't we implement these semantics? No, we don't. I will rework the patch series to make attempts to copy beyond the end of the source file return 0 to indicate that there is no more data to copy rather than return an error. Cheers, Dave. -- Dave Chinner david@fromorbit.com