* [PATCH] exec: make prepare_bprm_creds static
@ 2018-12-10 7:49 Chanho Min
2018-12-10 8:30 ` Michal Hocko
2018-12-10 8:39 ` Al Viro
0 siblings, 2 replies; 3+ messages in thread
From: Chanho Min @ 2018-12-10 7:49 UTC (permalink / raw)
To: Alexander Viro, Andrew Morton, Kees Cook, Eric W. Biederman,
David S. Miller, Michal Hocko, Alexei Starovoitov
Cc: linux-fsdevel, linux-kernel, Seungho Park, Chanho Min
prepare_bprm_creds is not used outside exec.c, so there's no reason for it
to have external linkage.
Signed-off-by: Chanho Min <chanho.min@lge.com>
---
fs/exec.c | 2 +-
include/linux/binfmts.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/exec.c b/fs/exec.c
index fc281b7..b6c9e5f 100644
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -1399,7 +1399,7 @@ EXPORT_SYMBOL(finalize_exec);
* Or, if exec fails before, free_bprm() should release ->cred and
* and unlock.
*/
-int prepare_bprm_creds(struct linux_binprm *bprm)
+static int prepare_bprm_creds(struct linux_binprm *bprm)
{
if (mutex_lock_interruptible(¤t->signal->cred_guard_mutex))
return -ERESTARTNOINTR;
diff --git a/include/linux/binfmts.h b/include/linux/binfmts.h
index e9f5fe6..6a9e43d 100644
--- a/include/linux/binfmts.h
+++ b/include/linux/binfmts.h
@@ -138,7 +138,6 @@ extern int transfer_args_to_stack(struct linux_binprm *bprm,
extern int bprm_change_interp(const char *interp, struct linux_binprm *bprm);
extern int copy_strings_kernel(int argc, const char *const *argv,
struct linux_binprm *bprm);
-extern int prepare_bprm_creds(struct linux_binprm *bprm);
extern void install_exec_creds(struct linux_binprm *bprm);
extern void set_binfmt(struct linux_binfmt *new);
extern ssize_t read_code(struct file *, unsigned long, loff_t, size_t);
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] exec: make prepare_bprm_creds static
2018-12-10 7:49 [PATCH] exec: make prepare_bprm_creds static Chanho Min
@ 2018-12-10 8:30 ` Michal Hocko
2018-12-10 8:39 ` Al Viro
1 sibling, 0 replies; 3+ messages in thread
From: Michal Hocko @ 2018-12-10 8:30 UTC (permalink / raw)
To: Chanho Min
Cc: Alexander Viro, Andrew Morton, Kees Cook, Eric W. Biederman,
David S. Miller, Alexei Starovoitov, linux-fsdevel, linux-kernel,
Seungho Park
On Mon 10-12-18 16:49:54, Chanho Min wrote:
> prepare_bprm_creds is not used outside exec.c, so there's no reason for it
> to have external linkage.
>
> Signed-off-by: Chanho Min <chanho.min@lge.com>
Acked-by: Michal Hocko <mhocko@suse.com>
> ---
> fs/exec.c | 2 +-
> include/linux/binfmts.h | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/exec.c b/fs/exec.c
> index fc281b7..b6c9e5f 100644
> --- a/fs/exec.c
> +++ b/fs/exec.c
> @@ -1399,7 +1399,7 @@ EXPORT_SYMBOL(finalize_exec);
> * Or, if exec fails before, free_bprm() should release ->cred and
> * and unlock.
> */
> -int prepare_bprm_creds(struct linux_binprm *bprm)
> +static int prepare_bprm_creds(struct linux_binprm *bprm)
> {
> if (mutex_lock_interruptible(¤t->signal->cred_guard_mutex))
> return -ERESTARTNOINTR;
> diff --git a/include/linux/binfmts.h b/include/linux/binfmts.h
> index e9f5fe6..6a9e43d 100644
> --- a/include/linux/binfmts.h
> +++ b/include/linux/binfmts.h
> @@ -138,7 +138,6 @@ extern int transfer_args_to_stack(struct linux_binprm *bprm,
> extern int bprm_change_interp(const char *interp, struct linux_binprm *bprm);
> extern int copy_strings_kernel(int argc, const char *const *argv,
> struct linux_binprm *bprm);
> -extern int prepare_bprm_creds(struct linux_binprm *bprm);
> extern void install_exec_creds(struct linux_binprm *bprm);
> extern void set_binfmt(struct linux_binfmt *new);
> extern ssize_t read_code(struct file *, unsigned long, loff_t, size_t);
> --
> 2.1.4
>
--
Michal Hocko
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] exec: make prepare_bprm_creds static
2018-12-10 7:49 [PATCH] exec: make prepare_bprm_creds static Chanho Min
2018-12-10 8:30 ` Michal Hocko
@ 2018-12-10 8:39 ` Al Viro
1 sibling, 0 replies; 3+ messages in thread
From: Al Viro @ 2018-12-10 8:39 UTC (permalink / raw)
To: Chanho Min
Cc: Andrew Morton, Kees Cook, Eric W. Biederman, David S. Miller,
Michal Hocko, Alexei Starovoitov, linux-fsdevel, linux-kernel,
Seungho Park
On Mon, Dec 10, 2018 at 04:49:54PM +0900, Chanho Min wrote:
> prepare_bprm_creds is not used outside exec.c, so there's no reason for it
> to have external linkage.
Applied...
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-10 8:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-10 7:49 [PATCH] exec: make prepare_bprm_creds static Chanho Min
2018-12-10 8:30 ` Michal Hocko
2018-12-10 8:39 ` Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).