From: Al Viro <viro@zeniv.linux.org.uk>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/2] proc: Protect readers of /proc/mounts from remount
Date: Tue, 11 Dec 2018 18:36:19 +0000 [thread overview]
Message-ID: <20181211183619.GF2217@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20181211172423.7709-3-jack@suse.cz>
On Tue, Dec 11, 2018 at 06:24:23PM +0100, Jan Kara wrote:
> Readers of /proc/mounts (and similar files) are currently unprotected
> from concurrently running remount on the filesystem they are reporting.
> This can not only result in bogus reported information but also in
> confusion in filesystems ->show_options callbacks resulting in
> use-after-free issues or similar (for example ext4 handling of quota
> file names is prone to such races).
>
> Fix the problem by protecting showing of mount information with
> sb->s_umount semaphore.
Umm... Which tree is it against and what exactly does your hold_sb() do?
next prev parent reply other threads:[~2018-12-11 18:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 17:24 [PATCH 0/2 RESEND] vfs: Fix crashes when reading /proc/mounts Jan Kara
2018-12-11 17:24 ` [PATCH 1/2] vfs: Provide function to grab superblock reference Jan Kara
2018-12-11 17:24 ` [PATCH 2/2] proc: Protect readers of /proc/mounts from remount Jan Kara
2018-12-11 18:36 ` Al Viro [this message]
2018-12-11 18:37 ` Al Viro
2018-12-11 18:58 ` Al Viro
2018-12-11 19:14 ` Al Viro
2018-12-12 12:56 ` Jan Kara
-- strict thread matches above, loose matches on Subject: below --
2018-12-18 13:46 [PATCH 0/2 v2] vfs: Fix crashes when reading /proc/mounts Jan Kara
2018-12-18 13:46 ` [PATCH 2/2] proc: Protect readers of /proc/mounts from remount Jan Kara
2018-10-18 13:17 [PATCH 0/2] vfs: Fix crashes when reading /proc/mounts Jan Kara
2018-10-18 13:17 ` [PATCH 2/2] proc: Protect readers of /proc/mounts from remount Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181211183619.GF2217@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).