From: Jens Axboe <axboe@kernel.dk>
To: linux-fsdevel@vger.kernel.org, linux-aio@kvack.org
Cc: hch@lst.de, viro@zeniv.linux.org.uk, Jens Axboe <axboe@kernel.dk>
Subject: [PATCH 5/7] aio: use iocb_put() instead of open coding it
Date: Sun, 16 Dec 2018 10:01:14 -0700 [thread overview]
Message-ID: <20181216170116.16944-6-axboe@kernel.dk> (raw)
In-Reply-To: <20181216170116.16944-1-axboe@kernel.dk>
Replace the percpu_ref_put() + kmem_cache_free() with a call to
iocb_put() instead.
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---
fs/aio.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/aio.c b/fs/aio.c
index ed6c3914477a..cf93b92bfb1e 100644
--- a/fs/aio.c
+++ b/fs/aio.c
@@ -1884,10 +1884,9 @@ static int io_submit_one(struct kioctx *ctx, struct iocb __user *user_iocb,
goto out_put_req;
return 0;
out_put_req:
- percpu_ref_put(&ctx->reqs);
if (req->ki_eventfd)
eventfd_ctx_put(req->ki_eventfd);
- kmem_cache_free(kiocb_cachep, req);
+ iocb_put(req);
out_put_reqs_available:
put_reqs_available(ctx, 1);
return ret;
--
2.17.1
next prev parent reply other threads:[~2018-12-16 17:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-16 17:01 [PATCHSET] aio cleanups and optimizations for 4.21 Jens Axboe
2018-12-16 17:01 ` [PATCH 1/7] aio: use assigned completion handler Jens Axboe
2018-12-16 17:01 ` [PATCH 2/7] aio: separate out ring reservation from req allocation Jens Axboe
2018-12-16 17:01 ` [PATCH 3/7] aio: don't zero entire aio_kiocb aio_get_req() Jens Axboe
2018-12-16 17:01 ` [PATCH 4/7] aio: only use blk plugs for > 2 depth submissions Jens Axboe
2018-12-16 17:01 ` Jens Axboe [this message]
2018-12-16 17:01 ` [PATCH 6/7] aio: split out iocb copy from io_submit_one() Jens Axboe
2018-12-16 17:01 ` [PATCH 7/7] aio: abstract out io_event filler helper Jens Axboe
2018-12-21 19:30 ` [PATCHSET] aio cleanups and optimizations for 4.21 Jeff Moyer
2018-12-22 15:26 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181216170116.16944-6-axboe@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).