linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: linux-fsdevel@vger.kernel.org, linux-aio@kvack.org
Cc: hch@lst.de, viro@zeniv.linux.org.uk
Subject: [PATCHSET v9] Support for polled and buffered aio (and more)
Date: Tue, 18 Dec 2018 08:42:08 -0700	[thread overview]
Message-ID: <20181218154230.3120-1-axboe@kernel.dk> (raw)

A few fixes and cleanups for the core part of this, and then a few
experimental patches at the end:

1) Add support for polling for the SQTHREAD. If enabled, this will
   poll the SQ ring for submissions, and (if polling is enabled), it
   will poll for completions and place them in the CQ ring. This means
   an application will never have to enter the kernel do do IO, it
   simply updates the SQ ring with what it needs. Currently the thread
   goes to sleep after an idle second, to avoid spinning all the time.
   But if IO is continually flowing, it will keep running. Some room
   for improvement here, with some sort of backoff in terms of spinning
   and sleeping, but the concept seems sound. When updating the SQ
   ring with new entries, the application needs to do:

   barrier();
   if (sq_ring->kflags & IORING_SQ_NEED_WAKEUP)
	   io_ring_enter(ctx, to_submit, 0, IORING_SUBMIT);

   in case the thread has gone to sleep. If IORING_SQ_NEED_WAKEUP isn't
   set, then no call needs to be made.

   This works both with polled IO, in which case the SQ thread will poll
   for completions too (as mentioned), and with buffered/O_DIRECT async
   aio. For the latter, completions end up in the CQ ring when the IRQ
   triggers.

2) Utilization of struct io_event ->res2. This is unused in the kernel.
   One idea is to populate this with meta data about the IO operation.
   For buffered aio, we can tell the application if the IO hit media or
   was served out of the page cache. These kinds of metrics may be useful
   for an application.

For the latter, the sample application I wrote:

http://git.kernel.dk/cgit/fio/plain/t/aio-ring.c

will give you by-the-second cache hit rates when run with buffered=1,
and fio with the aio-ring engine will do the same.

As before, find these patches in my aio-poll branch:

http://git.kernel.dk/cgit/linux-block/log/?h=aio-poll

or clone it here:

git://git.kernel.dk/linux-block aio-poll

and the code is based on my for-4.21/aio branch, which holds the aio
patches queued up for 4.21 already.

Changes since v8:

- Get rid of kmalloc/kfree for inline cached buffered aio
- Add IOCTX_FLAG_SQPOLL
- Correct syscall prototype in <linux/syscalls.h> to match actual syscall
- Add "IO was cached" hint to res2
- Fixed an issue with indexing fixed buffer mappings
- Check for fixed buffer location, EFAULT if app changed location
- Unify bio_iov_bvec_add_pages() and bio_iov_iter_get_pages()
- Split out prep patches
- Style fixups


 Documentation/filesystems/vfs.txt      |    3 +
 Documentation/sysctl/fs.txt            |    8 +-
 arch/x86/entry/syscalls/syscall_64.tbl |    2 +
 block/bio.c                            |   56 +-
 fs/aio.c                               | 1938 ++++++++++++++++++++++--
 fs/block_dev.c                         |   23 +-
 fs/file.c                              |   15 +-
 fs/file_table.c                        |    9 +-
 fs/gfs2/file.c                         |    2 +
 fs/iomap.c                             |   52 +-
 fs/xfs/xfs_file.c                      |    1 +
 include/linux/blk_types.h              |    2 +
 include/linux/file.h                   |    2 +
 include/linux/fs.h                     |    6 +-
 include/linux/iomap.h                  |    1 +
 include/linux/syscalls.h               |    4 +
 include/uapi/asm-generic/unistd.h      |    4 +-
 include/uapi/linux/aio_abi.h           |   47 +
 kernel/sys_ni.c                        |    2 +
 19 files changed, 1993 insertions(+), 184 deletions(-)

-- 
Jens Axboe

             reply	other threads:[~2018-12-18 15:42 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-18 15:42 Jens Axboe [this message]
2018-12-18 15:42 ` [PATCH 01/22] fs: add an iopoll method to struct file_operations Jens Axboe
2018-12-18 15:42 ` [PATCH 02/22] block: add REQ_HIPRI_ASYNC Jens Axboe
2018-12-21 11:20   ` Christoph Hellwig
2018-12-21 14:33     ` Jens Axboe
2018-12-18 15:42 ` [PATCH 03/22] block: wire up block device iopoll method Jens Axboe
2018-12-18 15:42 ` [PATCH 04/22] block: use REQ_HIPRI_ASYNC for non-sync polled IO Jens Axboe
2018-12-18 15:42 ` [PATCH 05/22] iomap: wire up the iopoll method Jens Axboe
2018-12-18 15:42 ` [PATCH 06/22] aio: add io_setup2() system call Jens Axboe
2018-12-21 11:21   ` Christoph Hellwig
2018-12-18 15:42 ` [PATCH 07/22] aio: support for IO polling Jens Axboe
2018-12-21 11:25   ` Christoph Hellwig
2018-12-21 14:28     ` Jens Axboe
2018-12-18 15:42 ` [PATCH 08/22] aio: add submission side request cache Jens Axboe
2018-12-21 11:28   ` Christoph Hellwig
2018-12-21 15:37     ` Jens Axboe
2018-12-21 15:42       ` Jens Axboe
2018-12-18 15:42 ` [PATCH 09/22] fs: add fget_many() and fput_many() Jens Axboe
2018-12-18 15:42 ` [PATCH 10/22] aio: use fget/fput_many() for file references Jens Axboe
2018-12-18 15:42 ` [PATCH 11/22] aio: split iocb init from allocation Jens Axboe
2018-12-18 15:42 ` [PATCH 12/22] aio: batch aio_kiocb allocation Jens Axboe
2018-12-18 15:42 ` [PATCH 13/22] aio: split old ring complete out from aio_complete() Jens Axboe
2018-12-18 15:42 ` [PATCH 14/22] aio: pass in user index to __io_submit_one() Jens Axboe
2018-12-18 15:42 ` [PATCH 15/22] aio: add support for submission/completion rings Jens Axboe
2018-12-18 15:42 ` [PATCH 16/22] block: add BIO_HOLD_PAGES flag Jens Axboe
2018-12-21 11:30   ` Christoph Hellwig
2018-12-21 14:22     ` Jens Axboe
2018-12-18 15:42 ` [PATCH 17/22] block: implement bio helper to add iter bvec pages to bio Jens Axboe
2018-12-21 11:32   ` Christoph Hellwig
2018-12-21 14:21     ` Jens Axboe
2018-12-18 15:42 ` [PATCH 18/22] aio: add support for pre-mapped user IO buffers Jens Axboe
2018-12-18 15:42 ` [PATCH 19/22] aio: support kernel side submission for aio with SCQRING Jens Axboe
2018-12-18 15:42 ` [PATCH 20/22] aio: enable polling for IOCTX_FLAG_SQTHREAD Jens Axboe
2018-12-18 15:42 ` [PATCH 21/22] aio: utilize io_event->res2 for CQ ring Jens Axboe
2018-12-18 15:42 ` [PATCH 22/22] aio: add my copyright Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181218154230.3120-1-axboe@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-aio@kvack.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).