From: Alexey Dobriyan <adobriyan@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
linux-fsdevel@vger.kernel.org,
"David Rientjes" <rientjes@google.com>
Subject: Re: [PATCH 1/2] procfs: signal /proc/PID/comm write truncation
Date: Fri, 21 Dec 2018 13:07:12 +0300 [thread overview]
Message-ID: <20181221100712.GA2106@avx2> (raw)
In-Reply-To: <20181220123833.c7305ae124845b36bc05cff6@linux-foundation.org>
On Thu, Dec 20, 2018 at 12:38:33PM -0800, Andrew Morton wrote:
> On Thu, 20 Dec 2018 00:28:04 +0100 Michał Mirosław <mirq-linux@rere.qmqm.pl> wrote:
>
> > Keeps truncation working, but also signals to writing process
> > when that happens.
>
> Please fully describe what is presently wrong with truncation. ie:
> describe the end-user-visible effects of a bug when fixing it.
Well, patch returns number of bytes actually copied instead of what
write(2) is given if truncation occurs.
But TASK_COMM_LEN was fixed since forever, none of this is needed.
Same for the second patch, lseek(SEEK_END) is unnecessary is
the size of the file is fixed.
next prev parent reply other threads:[~2018-12-21 10:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-19 23:28 [PATCH 0/2] procfs: /proc/PID/comm fixes Michał Mirosław
2018-12-19 23:28 ` [PATCH 1/2] procfs: signal /proc/PID/comm write truncation Michał Mirosław
2018-12-20 20:38 ` Andrew Morton
2018-12-21 10:07 ` Alexey Dobriyan [this message]
2019-01-13 12:49 ` Michał Mirosław
2018-12-19 23:28 ` [PATCH 2/2] procfs: lseek(/proc/PID/comm, 0, SEEK_END) Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181221100712.GA2106@avx2 \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).