From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 21 Dec 2018 06:48:40 -0800 From: Matthew Wilcox To: Nikolay Borisov Cc: linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] mm: Refactor readahead defines in mm.h Message-ID: <20181221144840.GB10600@bombadil.infradead.org> References: <20181221144053.24318-1-nborisov@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181221144053.24318-1-nborisov@suse.com> Sender: owner-linux-mm@kvack.org List-ID: On Fri, Dec 21, 2018 at 04:40:53PM +0200, Nikolay Borisov wrote: > All users of VM_MAX_READAHEAD actually convert it to kbytes and then to > pages. Define the macro explicitly as (SZ_128K / PAGE_SIZE). This > simplifies the expression in every filesystem. Also rename the macro to > VM_READAHEAD_PAGES to properly convey its meaning. Finally remove unused > VM_MIN_READAHEAD > > Signed-off-by: Nikolay Borisov Reviewed-by: Matthew Wilcox