linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Christoph Hellwig <hch@lst.de>,
	linux-xfs@vger.kernel.org,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Piotr Jaroszynski <pjaroszynski@nvidia.com>,
	william.kucharski@oracle.com, stable@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] iomap: Revert "fs/iomap.c: get/put the page in iomap_page_create/release()"
Date: Sat, 22 Dec 2018 08:58:32 +1100	[thread overview]
Message-ID: <20181221215832.GF4205@dastard> (raw)
In-Reply-To: <CAHk-=wjL7m3fLj1sVH91dcW51Qk4B9S7Q7OKf7dna6j+QoB5=w@mail.gmail.com>

On Fri, Dec 21, 2018 at 11:18:35AM -0800, Linus Torvalds wrote:
> Dave,
>  any chance you can validate Christoph's patch and we could re-apply the fix?

Not for a few days - I'm out of the office until after xmas now.

I did notice the same bug in the original patch yesterday (and
mentioned it to Darrick on #xfs) when doing post-mortem analysis,
but I couldn't tell if that was the only problem all my test
machines were tied up testing that the revert didn't
introduce/uncover any new problems...

I'll test it as soon as I'm back around the office so we can get it
in -rc1 if there's no problems.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

      parent reply	other threads:[~2018-12-21 21:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-20 12:23 [PATCH] iomap: Revert "fs/iomap.c: get/put the page in iomap_page_create/release()" Dave Chinner
2018-12-20 12:28 ` Greg KH
2018-12-20 20:57   ` Dave Chinner
2018-12-21  7:40     ` Greg KH
2018-12-21 22:06       ` Eric Sandeen
2018-12-22  0:04       ` Sasha Levin
2018-12-20 17:41 ` Christoph Hellwig
2018-12-20 20:53   ` Dave Chinner
2018-12-20 22:42     ` Linus Torvalds
2018-12-21  9:39       ` Christoph Hellwig
2018-12-21 19:18         ` Linus Torvalds
2018-12-21 19:20           ` Christoph Hellwig
2018-12-21 19:26             ` Linus Torvalds
2018-12-21 21:58           ` Dave Chinner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181221215832.GF4205@dastard \
    --to=david@fromorbit.com \
    --cc=akpm@linux-foundation.org \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=pjaroszynski@nvidia.com \
    --cc=stable@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=william.kucharski@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).