From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail-wr1-f52.google.com ([209.85.221.52]:33735 "EHLO
        mail-wr1-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725869AbeLZGTC (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Wed, 26 Dec 2018 01:19:02 -0500
Date: Wed, 26 Dec 2018 09:18:56 +0300
From: Alexey Dobriyan <adobriyan@gmail.com>
To: Kangjie Lu <kjlu@umn.edu>
Cc: pakki001@umn.edu, Andrew Morton <akpm@linux-foundation.org>,
        Davidlohr Bueso <dbueso@suse.de>,
        David Howells <dhowells@redhat.com>,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fs: proc: check status of register_filesystem
Message-ID: <20181226061856.GA2122@avx2>
References: <20181226030642.72757-1-kjlu@umn.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20181226030642.72757-1-kjlu@umn.edu>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, Dec 25, 2018 at 09:06:40PM -0600, Kangjie Lu wrote:
> register_filesystem() could fail. The fix issues an error message if it
> fails.

> -	register_filesystem(&proc_fs_type);
> +	if (register_filesystem(&proc_fs_type))
> +		pr_err("failed to register the filesystem.\n");

No, register_filesystem() should do it.