From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.133]:53146 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727987AbeL0Nz3 (ORCPT ); Thu, 27 Dec 2018 08:55:29 -0500 Date: Thu, 27 Dec 2018 14:55:09 +0100 From: Christoph Hellwig To: Jens Axboe Cc: linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, linux-block@vger.kernel.org, hch@lst.de, viro@zeniv.linux.org.uk Subject: Re: [PATCH 07/22] aio: add io_setup2() system call Message-ID: <20181227135509.GA25525@infradead.org> References: <20181221192236.12866-1-axboe@kernel.dk> <20181221192236.12866-8-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181221192236.12866-8-axboe@kernel.dk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Dec 21, 2018 at 12:22:21PM -0700, Jens Axboe wrote: > This is just like io_setup(), except add a flags argument to let the > caller control/define some of the io_context behavior. > > Outside of the flags, we add two user pointers for future use. > > Reviewed-by: Christoph Hellwig Hmm, I don't think think I was fine with the current version.. > +/* sys_io_setup2: > + * Like sys_io_setup(), except that it takes a set of flags > + * (IOCTX_FLAG_*), and some pointers to user structures: > + * > + * *user1 - reserved for future use > + * > + * *user2 - reserved for future use. > + */ > +SYSCALL_DEFINE5(io_setup2, u32, nr_events, u32, flags, void __user *, user1, > + void __user *, user2, aio_context_t __user *, ctxp) Most importantly I'm really worried about these new user1 and user2 fields, which aren't really used for aio poll. They are used for the I/O ring, which while I think is a really great concept, I am also worried about overlaying into the aio interface just creating confusion..