Re: [heads-up] buggered refcounting logics in cgroup1_mount()

[Tejun Heo <tj@kernel.org>]

Hello, Al.

On Sat, Jan 12, 2019 at 09:52:15PM +0000, Al Viro wrote:
> > See vfs.git #fixes (the last two commits in there).  It seems to
> > work here, but I don't have the CRIU regression tests, etc., so
> > I would really appreciate if that thing got a real beating.
> 
> BTW, while kernfs_pin_sb() and struct kernfs_root ->supers definitely
> ought to die, there's something else that might be killable with that
> approach.  percpu_ref_reinit() has no users left after that, and,
> as David Howells has observed, PERCPU_REF_INIT_DEAD is also unused.
> 
> Do we want to keep these two?

Sorry about the delay.

* The patches look good to me.  That said, of the two patches, I think
  it'd be probably better to send only the first one to -stable.  As
  there haven't been any bug reports against the mount behavior for
  some years now, I don't think there's a need to backport the bigger
  change.  Any change carries some risk after all.

* Please feel free to remove percpu_ref_reinit() and unused parts.
  It's easy enough to add it back later if necessary.

* How do you wanna route the patches?

Thanks.

-- 
tejun