From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6204EC282F6 for ; Mon, 21 Jan 2019 09:35:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2763820989 for ; Mon, 21 Jan 2019 09:35:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="J5h9BOvf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727519AbfAUJfO (ORCPT ); Mon, 21 Jan 2019 04:35:14 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:54028 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727190AbfAUJfO (ORCPT ); Mon, 21 Jan 2019 04:35:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=gBr6vDEhnU86RA+1WLJpa4/MxnEypO+40f7Ew6KYN3w=; b=J5h9BOvfdyB7iOXAYTvW/+uBq ZlCpINX9tdAG9wcU97qkUPdX+O0wjY/STaosazD9/8KznCBDvbV/VEcMl8ViJyLQquvyyxnEHm0ti zWUu6zAsVHzUAhSbVbr3QjPxP3cqDjGSKXKDJpb9rW7czqhIWPTy0VceVXeAttrvhfF/k4n0qLugu EQkmxDw4plMYl24zbnEaFKPbrK/OvratiwH5gy7Jd0oTXzU4uCEMAjtzcTA9g6ZLqTnRdb+KFNarm cXKyqI2EcL9vb3haFHLGvEor5O3d9bJhpLa32C+APjiKm2+NWaxPH4hpAEWvSEfi2EHCtJ0vbwklN WvYMkP1SQ==; Received: from willy by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1glVz5-0007yb-4e; Mon, 21 Jan 2019 09:35:11 +0000 Date: Mon, 21 Jan 2019 01:35:10 -0800 From: Matthew Wilcox To: Phillip Potter Cc: viro@zeniv.linux.org.uk, jack@suse.cz, amir73il@gmail.com, linux-fsdevel@vger.kernel.org Subject: Re: [RFC][PATCH v5 00/09] common implementation of dirent file types Message-ID: <20190121093510.GA11365@bombadil.infradead.org> References: <20190121005425.GA32315@pathfinder> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190121005425.GA32315@pathfinder> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Jan 21, 2019 at 12:54:25AM +0000, Phillip Potter wrote: > These patches mostly no longer include compile-time checks to ensure > the filesystem specific on-disk bits are equivalent to the common > implementation FT_* bits, and instead op to remove the filesystem > specific definitions entirely where possible, as a result of the > referenced discussion above. > > With the ext4 patch, the EXT4_FT_* definitions are instead defined > to be FT_*, to give less code churn with the same result (no need > to modify fs/ext4/namei.c). Also, the nilfs2 and btrfs filesystems > keep their filesystem specific definitions in the include/uapi/linux > directory, so these cannot be changed trivially without breaking > userspace. For this reason, the compile time checks remain in these > two filesystems. Just because something is exposed through the uapi directory today doesn't mean userspace actually uses it. For example, https://codesearch.debian.net/search?q=BTRFS_FT_DIR The only code which uses the filetype defines is going to be code which actually looks at a raw filesystem image. All three examples of userspace code in Debian have their own definitions instead of using the one which the kernel provides.