From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB63FC37122 for ; Tue, 22 Jan 2019 00:04:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5984C21721 for ; Tue, 22 Jan 2019 00:04:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DOWU3MHp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725994AbfAVAE2 (ORCPT ); Mon, 21 Jan 2019 19:04:28 -0500 Received: from mail-qk1-f194.google.com ([209.85.222.194]:46562 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725941AbfAVAE2 (ORCPT ); Mon, 21 Jan 2019 19:04:28 -0500 Received: by mail-qk1-f194.google.com with SMTP id q1so13265939qkf.13 for ; Mon, 21 Jan 2019 16:04:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=NkzZ7l+1JeOOyeEqIYYM0g2NkUZZToqMygqOjJD2Mwk=; b=DOWU3MHp/emT9n9T7OrIvpKmTxzbTSlaw6VZjqz1B9ZNgFO2/peBGlN4zBQKcOZR+u 2EyAXpTeQ+sD9vZNE+fiS5BQbDNK8zm1Y4IOnIZhYRuADd7TNb1XilT1T2lmknnjaZBR nK+0iNmuiT+m/A7vHgxWS6rruvmi0Cj8QRYwO+HC8/uXJahFuD8+sOJpu7Nw82dqYVsS H713tUyCvdKBfMEEMG1nAl0kXHu8f6+bLOOs4UoAvI1Os16YW+5z5SG+scjX2OCXd6sn StLvOzb93EbfwSPwR2ziA+kcmhsiy0nOXDuJf6qmJqpReJ7Tn23UlU8QXYMTosiotMsB orOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=NkzZ7l+1JeOOyeEqIYYM0g2NkUZZToqMygqOjJD2Mwk=; b=TJfIe8LEcTWGSOJgvNuMKvArg+rbAsiczmb+VpJHIJ9wH9EyMka5xkh109zDDfRARq kxdIXq6cgKpc0a8x0OM3yOA/3kBg5aNtD5LvsME7BCY0BUHkSwI93MUbqiVcUqPZD8eG AEc2HLhROtoUb3j84BG/jApktUWib6Pq0QeQxLzvykNQjrc33DmkfuB+qZZJgiLNxhni BudhQ+FDZgy1mhjcU3U9LXa5voT4DlZX2Cccb2snV1dQxTVpq+H7ZygzhjKG7i2D0GjD HFWVZoWY2KRyrdfAx3ywCn6jEJ4UK7WPR47V9bny0bO10riSsCRO4VZel0JcuJY4hTqU 3MDQ== X-Gm-Message-State: AJcUuke1T5CvXQBGtI4ph99Q4lHef6DW/f/T6vh2FhDuwMajlci7F9gY zzMJqaZ6jSFp9i89cR5yYfM= X-Google-Smtp-Source: ALg8bN4Bso2lbvUt4lKtXNdpP7/br/vyo6oUYpECuEN0r+V6kR1QMizMFFudAvY/jMdFwvGupU31Pw== X-Received: by 2002:a37:96c2:: with SMTP id y185mr25114692qkd.239.1548115467353; Mon, 21 Jan 2019 16:04:27 -0800 (PST) Received: from eaf ([190.19.101.95]) by smtp.gmail.com with ESMTPSA id o25sm69729817qtj.10.2019.01.21.16.04.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Jan 2019 16:04:26 -0800 (PST) Date: Mon, 21 Jan 2019 21:04:21 -0300 From: Ernesto =?utf-8?Q?A=2E_Fern=C3=A1ndez?= To: Jens Axboe Cc: Jan Kara , linux-fsdevel@vger.kernel.org, Alexander Viro , Jeff Moyer Subject: Re: [PATCH] direct-io: allow direct writes to empty inodes Message-ID: <20190122000421.cmzcshm2kbe5jcfw@eaf> References: <20181008235823.5rpr4dqgriiacsvy@eaf> <20181026093004.GA25227@quack2.suse.cz> <906a14c3-0b0c-8591-6269-219316d4bdfa@kernel.dk> <20181027041205.ui6j3awevfttozgf@eaf> <11f495f4-c51d-4676-f539-019b4006cbad@kernel.dk> <20190107180308.gsnqimqmmabwnwfc@eaf> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190107180308.gsnqimqmmabwnwfc@eaf> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Jan 07, 2019 at 03:03:08PM -0300, Ernesto A. Fernández wrote: > On Sat, Oct 27, 2018 at 10:54:09AM -0600, Jens Axboe wrote: > > On 10/26/18 10:12 PM, Ernesto A. Fernández wrote: > > > On Fri, Oct 26, 2018 at 08:29:00AM -0600, Jens Axboe wrote: > > >> On 10/26/18 3:30 AM, Jan Kara wrote: > > >>> On Mon 08-10-18 20:58:23, Ernesto A. Fernández wrote: > > >>>> On a DIO_SKIP_HOLES filesystem, the ->get_block() method is currently > > >>>> not allowed to create blocks for an empty inode. This confusion comes > > >>>> from trying to bit shift a negative number, so check the size of the > > >>>> inode first. > > >>>> > > >>>> The problem is most visible for hfsplus, because the fallback to > > >>>> buffered I/O doesn't happen and the write fails with EIO. This is in > > >>>> part the fault of the module, because it gives a wrong return value on > > >>>> ->get_block(); that will be fixed in a separate patch. > > >>>> > > >>>> Signed-off-by: Ernesto A. Fernández > > >>> > > >>> Good catch. The patch looks good. You can add: > > >>> > > >>> Reviewed-by: Jan Kara > > >>> > > >>> Also Jens often picks up patches for direct IO code so added him to CC. > > >>> Jens? > > >> > > >> Looks good to me. Ernesto, did you run this through xfstests as well? > > > > > > I only ran the quick tests for ext2. Also for hfsplus, but those are not > > > very meaningful because too many are failing. > > > > OK, that's useful. I'll run it through the whole thing just in case, > > but I don't expect to find anything. > > So what happened with this patch? Any issues? Ping? > > > > > -- > > Jens Axboe > >