Re: [PATCH v3 1/2] 9p: use inode->i_lock to protect i_size_write() under 32-bit

[Dominique Martinet <asmadeus@codewreck.org>]

Hou Tao wrote on Thu, Jan 24, 2019:
> @@ -83,4 +88,17 @@ static inline void v9fs_invalidate_inode_attr(struct inode *inode)
>  }
>  
>  int v9fs_open_to_dotl_flags(int flags);
> +
> +static inline void v9fs_i_size_write(struct inode *inode, loff_t i_size)
> +{
> +	/*
> +	 * Avoid taking i_lock under 64-bit.
> +	 * Refer to fsstack_copy_inode_size() for detailed explanation.
> +	 */

Just one last nitpick here: I'd rather not reference to another function
for comment; the 9p code doesn't change much and if someone ever changes
fsstack_copy_inode_size it'll probably go unnoticed for a while.

If you're OK with this I can change it myself, but got other comments
for second patch so up to you.

More than happy with the rest, I'll run some tests over the weekend for
the sake of it but should take this patch to -next early next week
assuming we agree on something for the comment.

-- 
Dominique