From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D0E3C282C3 for ; Thu, 24 Jan 2019 06:57:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 33C932184C for ; Thu, 24 Jan 2019 06:57:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726089AbfAXG5u (ORCPT ); Thu, 24 Jan 2019 01:57:50 -0500 Received: from nautica.notk.org ([91.121.71.147]:38946 "EHLO nautica.notk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725939AbfAXG5u (ORCPT ); Thu, 24 Jan 2019 01:57:50 -0500 Received: by nautica.notk.org (Postfix, from userid 1001) id 54672C009; Thu, 24 Jan 2019 07:57:48 +0100 (CET) Date: Thu, 24 Jan 2019 07:57:33 +0100 From: Dominique Martinet To: Hou Tao Cc: v9fs-developer@lists.sourceforge.net, lucho@ionkov.net, ericvh@gmail.com, linux-fsdevel@vger.kernel.org, xingaopeng@huawei.com Subject: Re: [PATCH v3 1/2] 9p: use inode->i_lock to protect i_size_write() under 32-bit Message-ID: <20190124065733.GA21444@nautica> References: <20190124063514.8571-1-houtao1@huawei.com> <20190124063514.8571-2-houtao1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190124063514.8571-2-houtao1@huawei.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Hou Tao wrote on Thu, Jan 24, 2019: > @@ -83,4 +88,17 @@ static inline void v9fs_invalidate_inode_attr(struct inode *inode) > } > > int v9fs_open_to_dotl_flags(int flags); > + > +static inline void v9fs_i_size_write(struct inode *inode, loff_t i_size) > +{ > + /* > + * Avoid taking i_lock under 64-bit. > + * Refer to fsstack_copy_inode_size() for detailed explanation. > + */ Just one last nitpick here: I'd rather not reference to another function for comment; the 9p code doesn't change much and if someone ever changes fsstack_copy_inode_size it'll probably go unnoticed for a while. If you're OK with this I can change it myself, but got other comments for second patch so up to you. More than happy with the rest, I'll run some tests over the weekend for the sake of it but should take this patch to -next early next week assuming we agree on something for the comment. -- Dominique