From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94CF2C282C3 for ; Thu, 24 Jan 2019 09:27:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 62A6421872 for ; Thu, 24 Jan 2019 09:27:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=philpotter-co-uk.20150623.gappssmtp.com header.i=@philpotter-co-uk.20150623.gappssmtp.com header.b="Ap1Sk6LY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726012AbfAXJ1l (ORCPT ); Thu, 24 Jan 2019 04:27:41 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:55977 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725931AbfAXJ1l (ORCPT ); Thu, 24 Jan 2019 04:27:41 -0500 Received: by mail-wm1-f67.google.com with SMTP id y139so2281558wmc.5 for ; Thu, 24 Jan 2019 01:27:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philpotter-co-uk.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=VjLplEKIKxOlOlXoTjMZEwhZQT+wZ3ujL3mTsQ6lUbI=; b=Ap1Sk6LYyc6sX1pkdNRa1Wf/SCpEWvHoMOYa7lBYkdjlZDzK+PxoGCFFp0iF2wNc4w JvI//MVymZguZecFgRjfS+BSzWOcKaJ6b8WYi1m2hAftiPiBSMT38PyfZbkXgjHGJYu7 Ym3jDiPER6bGLoMlgJJpgzypyzkB5dtTNHoHZtacb7MvSwYYhoGfDTiCUZ1SLVeAfoUd rY+T0Uy2dkRFYGhtZjmL1e0zZ0Mb+7Ak0e5vUTMFzWdtN2Lt5D74wHH8m8VbpaW6dzhp lXRM1a3dmbUL9bsw0QdOP61YlBET3qCPDJma6C9q7JFiTpvoNJirXNOrs/PNr6pGjuSy vGww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=VjLplEKIKxOlOlXoTjMZEwhZQT+wZ3ujL3mTsQ6lUbI=; b=I8KZmChZSfz161GB93cbekEdDvktBtC7c/JBpImw6HMtKQEmymOTmEpkIiIYw8dNNv mjTC0b/ovkfG0f60H1SrQLKP31/jO/+azQJy2qLcPbd/1ilu2+UESxw8r3ADlsJI5sHw IvGQD3TyRZ0n2mdxhQ9RPLUP1YU5bZNL1RkwpcHXo6R+9Xa5LBVVy3TFiWYLTU1x1dY/ Utl/L/l4tQ8fA/vAqRvHmgn5gR9boaHEQq0P136kMLwfNHZFV1bUdTb1PfJiNXQwPaOa 0cS8F5RAhQrLnVolfSovCRZQZbsgCAUkZduyAkkHJmcLx/IUFOJqTgBLi7kACnQNCFrw leCw== X-Gm-Message-State: AJcUukcOkBe3AKhkyKMfB4vqilTp6QdgyTIE9MUvZ+wKnf8WxEN9YSuz fQSx9PYUBwAFMrnqVsjV82s26w== X-Google-Smtp-Source: ALg8bN6SgB70CnRClRFiCnNLO17WSO7JsAdBVYH69rZVaoern1p2zE2etDDLIpk72cYsJ58e3TT/rw== X-Received: by 2002:a1c:6442:: with SMTP id y63mr1685973wmb.143.1548322059536; Thu, 24 Jan 2019 01:27:39 -0800 (PST) Received: from pathfinder ([90.222.17.17]) by smtp.gmail.com with ESMTPSA id h16sm205133067wrb.62.2019.01.24.01.27.38 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 24 Jan 2019 01:27:38 -0800 (PST) Date: Thu, 24 Jan 2019 09:27:37 +0000 From: Phillip Potter To: Chao Yu Cc: amir73il@gmail.com, viro@zeniv.linux.org.uk, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, jaegeuk@kernel.org Subject: Re: [RFC][PATCH v5 06/09] f2fs: use common file type conversion Message-ID: <20190124092737.GA25629@pathfinder> References: <20190121005434.GA32358@pathfinder> <6f759f75-5906-e499-e86b-a915d714e8c4@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6f759f75-5906-e499-e86b-a915d714e8c4@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Jan 23, 2019 at 02:27:34PM +0800, Chao Yu wrote: > On 2019/1/21 8:54, Phillip Potter wrote: > > Deduplicate the f2fs file type conversion implementation and remove > > F2FS_FT_* definitions - file systems that use the same file types > > as defined by POSIX do not need to define their own versions and can > > use the common helper functions decared in fs_types.h and implemented > > in fs_types.c > > > > Signed-off-by: Amir Goldstein > > Signed-off-by: Phillip Potter > > Reviewed-by: Chao Yu > > Thanks, > Thank you very much for this. Regards, Phil