From: Dan Carpenter <dan.carpenter@oracle.com>
To: Christian Brauner <christian@brauner.io>
Cc: devel@driverdev.osuosl.org, tkjos@android.com,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
joel@joelfernandes.org, arve@android.com,
Martijn Coenen <maco@google.com>,
linux-fsdevel@vger.kernel.org, maco@android.com,
tkjos@google.com
Subject: Re: [PATCH] binder: fix CONFIG_ANDROID_BINDER_DEVICES
Date: Mon, 28 Jan 2019 14:49:26 +0300 [thread overview]
Message-ID: <20190128114926.GE1795@kadam> (raw)
In-Reply-To: <20190128114729.GD1795@kadam>
On Mon, Jan 28, 2019 at 02:47:29PM +0300, Dan Carpenter wrote:
> On Sat, Jan 26, 2019 at 11:23:20AM +0100, Christian Brauner wrote:
> > Several users have tried to only rely on binderfs to provide binder devices
> > and set CONFIG_ANDROID_BINDER_DEVICES="" empty. This is a great use-case of
> > binderfs and one that was always intended to work. However, this is
> > currently not possible since setting CONFIG_ANDROID_BINDER_DEVICES="" emtpy
> > will simply panic the kernel:
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> It should just do a WARN() and not panic the kernel.
>
Oh... They have panic on warn set up probably. Never mind.
regards,
dan carpenter
next prev parent reply other threads:[~2019-01-28 11:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-26 10:23 [PATCH] binder: fix CONFIG_ANDROID_BINDER_DEVICES Christian Brauner
2019-01-28 11:47 ` Dan Carpenter
2019-01-28 11:49 ` Dan Carpenter [this message]
2019-01-28 17:33 ` Todd Kjos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190128114926.GE1795@kadam \
--to=dan.carpenter@oracle.com \
--cc=arve@android.com \
--cc=christian@brauner.io \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joel@joelfernandes.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=maco@google.com \
--cc=tkjos@android.com \
--cc=tkjos@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).