From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC1C0C282C8 for ; Mon, 28 Jan 2019 14:04:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7C3A220989 for ; Mon, 28 Jan 2019 14:04:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="CK4lZeeZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726995AbfA1OEi (ORCPT ); Mon, 28 Jan 2019 09:04:38 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:45202 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726895AbfA1OEi (ORCPT ); Mon, 28 Jan 2019 09:04:38 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id x0SE3lRL121953; Mon, 28 Jan 2019 14:04:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : mime-version : content-type; s=corp-2018-07-02; bh=uN/6ZCje08L3U98NyOdZ4Q9xY+9LtlnMoO1y4In3aOM=; b=CK4lZeeZXG9/Wt7DMdwNbYHKAqmd7ImklKi86RJcui3sdXBdW2KEXi0UkumDfuuciRde 6D5uWDDQo/Ty54U2dg4sxVPFzNht81jyqoKnucRx2tENRsVRJLISZ5kFy53Ea9Rpup5s gpSnQezLbs9UbHJL6yLnmEqDygbejEY29UTA1vkVYpHwaSr9aBgWvNJ6+oGt9TS34VEJ VREYqLguqmrBMc54C0jGVezDNlW6Dz32/CfCEu7NW0RfRrZrlDFKvLx4kz4lMLehhW4t PdziUHgc1EiwoXjIp7Ef3FgA2TJ87XuSFnr433cs1lTU0BlxRzGCHrxH3f8lNVOqesjj 6w== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2120.oracle.com with ESMTP id 2q8g6qx6je-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 28 Jan 2019 14:04:34 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id x0SE4XDv012965 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 28 Jan 2019 14:04:33 GMT Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x0SE4WZH023541; Mon, 28 Jan 2019 14:04:33 GMT Received: from kadam (/197.157.34.178) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 28 Jan 2019 06:04:32 -0800 Date: Mon, 28 Jan 2019 17:04:26 +0300 From: Dan Carpenter To: dhowells@redhat.com Cc: linux-fsdevel@vger.kernel.org Subject: [bug report] smack: Implement filesystem context security hooks Message-ID: <20190128140426.GA7268@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9149 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=919 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1901280110 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Hello David Howells, The patch 1f38a2e9dab7: "smack: Implement filesystem context security hooks" from Nov 1, 2018, leads to the following static checker warning: fs/namespace.c:1014 vfs_kern_mount() error: passing non negative 1 to ERR_PTR fs/namespace.c 1004 return ERR_CAST(fc); 1005 1006 if (name) 1007 ret = vfs_parse_fs_string(fc, "source", 1008 name, strlen(name)); 1009 if (!ret) 1010 ret = parse_monolithic_mount_data(fc, data); 1011 if (!ret) 1012 mnt = fc_mount(fc); 1013 else --> 1014 mnt = ERR_PTR(ret); 1015 1016 put_fs_context(fc); 1017 return mnt; 1018 } The 1 comes from selinux_fs_context_parse_param() and smack_fs_context_parse_param(). That code looks something like: security/smack/smack_lsm.c 707 /** 708 * smack_fs_context_parse_param - Parse a single mount parameter 709 * @fc: The new filesystem context being constructed. 710 * @param: The parameter. 711 * 712 * Returns 0 on success or -ENOMEM on error. ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ LIES!!!! 713 */ 714 static int smack_fs_context_parse_param(struct fs_context *fc, 715 struct fs_parameter *param) 716 { 717 struct fs_parse_result result; 718 int opt, rc; 719 720 opt = fs_parse(fc, &smack_fs_parameters, param, &result); 721 if (opt < 0) 722 return opt; 723 724 rc = smack_add_opt(opt, param->string, &fc->security); 725 if (!rc) { 726 param->string = NULL; 727 rc = 1; ^^^^^^ It probably should return zero though... 728 } 729 return rc; 730 } regards, dan carpenter