From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21CA7C282C2 for ; Thu, 7 Feb 2019 23:39:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E66B621721 for ; Thu, 7 Feb 2019 23:39:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549582756; bh=Z2htgOGIsmWRReFjWRkFUANDBsCnerQJgWQ1hqHi9Y0=; h=Date:From:To:Subject:References:In-Reply-To:List-ID:From; b=OiSOKZcyod9dIXBKBxSztKp8sRLY+WFHumWG8NTsUi/5LRcCRQt21bY+dnoMezzn0 69ohbuaW2uALxAmSA68RkIqPPU+M6vwbHs+np4RCbQAqTlKeyga8uey+w0v+AhgJuA S9LU99W/55JmJHgUALoc8E1dD7MY+wQ2r7J9BZjw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726728AbfBGXjP (ORCPT ); Thu, 7 Feb 2019 18:39:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:52508 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726622AbfBGXjP (ORCPT ); Thu, 7 Feb 2019 18:39:15 -0500 Received: from gmail.com (unknown [104.132.1.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 74FF12085A; Thu, 7 Feb 2019 23:39:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549582754; bh=Z2htgOGIsmWRReFjWRkFUANDBsCnerQJgWQ1hqHi9Y0=; h=Date:From:To:Subject:References:In-Reply-To:From; b=erZQcweBuw2VL5ihqgTcKxnnGeKxYF6u6ihQj2/7AIGgicdn0uIPLv8vrfdulnJ3D jSAgImLmoPfeG9HYZsh2vSzhM2tkaEBoqvk20lU0C7R4gp1uioH8/tjrYX04e0Ka1M QyIjzC+T7WrLJAd+CvHKK1KBebXwExtrZ1fkQFR0= Date: Thu, 7 Feb 2019 15:39:13 -0800 From: Eric Biggers To: linux-fsdevel@vger.kernel.org, Alexander Viro Subject: Re: [PATCH RESEND] fs/read_write.c: make __vfs_write() static Message-ID: <20190207233912.GF125156@gmail.com> References: <20190110204153.120176-1-ebiggers@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190110204153.120176-1-ebiggers@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Jan 10, 2019 at 12:41:53PM -0800, Eric Biggers wrote: > From: Eric Biggers > > __vfs_write() is only used in fs/read_write.c, so make it static. > > This addresses a gcc warning when -Wmissing-prototypes is enabled. > > Signed-off-by: Eric Biggers > --- > fs/read_write.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/read_write.c b/fs/read_write.c > index ff3c5e6f87cfa..4b328e45db366 100644 > --- a/fs/read_write.c > +++ b/fs/read_write.c > @@ -478,8 +478,8 @@ static ssize_t new_sync_write(struct file *filp, const char __user *buf, size_t > return ret; > } > > -ssize_t __vfs_write(struct file *file, const char __user *p, size_t count, > - loff_t *pos) > +static ssize_t __vfs_write(struct file *file, const char __user *p, > + size_t count, loff_t *pos) > { > if (file->f_op->write) > return file->f_op->write(file, p, count, pos); > -- > 2.20.1.97.g81188d93c3-goog > Ping. Al, are you planning to apply this? - Eric