Re: [PATCH RESEND] fs/buffer.c: include fs/internal.h for missing prototypes

[Eric Biggers <ebiggers@kernel.org>]

On Thu, Jan 10, 2019 at 12:40:41PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
> 
> __block_write_begin_int(), __generic_write_end(), and guard_bio_eod()
> are defined in fs/buffer.c and declared in fs/internal.h, but the
> declarations aren't included at the point of the definitions.  Include
> the header to enforce that the definitions match the declarations.
> 
> This addresses gcc warnings when -Wmissing-prototypes is enabled.
> 
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
>  fs/buffer.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/buffer.c b/fs/buffer.c
> index 52d024bfdbc12..7a9937b0cb9f3 100644
> --- a/fs/buffer.c
> +++ b/fs/buffer.c
> @@ -46,6 +46,7 @@
>  #include <linux/pagevec.h>
>  #include <linux/sched/mm.h>
>  #include <trace/events/block.h>
> +#include "internal.h"
>  
>  static int fsync_buffers_list(spinlock_t *lock, struct list_head *list);
>  static int submit_bh_wbc(int op, int op_flags, struct buffer_head *bh,
> -- 
> 2.20.1.97.g81188d93c3-goog
> 

Ping.  Al, are you planning to apply this?

- Eric