From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16CF5C282CE for ; Mon, 11 Feb 2019 16:48:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E50E121B1A for ; Mon, 11 Feb 2019 16:48:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729505AbfBKQsO (ORCPT ); Mon, 11 Feb 2019 11:48:14 -0500 Received: from verein.lst.de ([213.95.11.211]:58809 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728968AbfBKQsN (ORCPT ); Mon, 11 Feb 2019 11:48:13 -0500 Received: by newverein.lst.de (Postfix, from userid 2407) id 448C968DD6; Mon, 11 Feb 2019 17:48:11 +0100 (CET) Date: Mon, 11 Feb 2019 17:48:11 +0100 From: Christoph Hellwig To: Carlos Maiolino Cc: Christoph Hellwig , Andreas Dilger , "Darrick J. Wong" , linux-fsdevel , Eric Sandeen , david@fromorbit.com Subject: Re: [PATCH 09/10 V2] Use FIEMAP for FIBMAP calls Message-ID: <20190211164811.GA30217@lst.de> References: <20181205173650.GA8112@magnolia> <20190204151147.rra4n7k56ec4ndob@hades.usersys.redhat.com> <20190204182722.GA32119@magnolia> <20190206133753.oqpw7citye6apdpr@hades.usersys.redhat.com> <20190206204431.GB32119@magnolia> <0258844F-A305-4744-8C70-B27A3E49ADEC@dilger.ca> <20190207095233.imqha36zgoqilxx2@hades.usersys.redhat.com> <20190208084352.GA23194@lst.de> <20190211125708.GA21583@lst.de> <20190211162140.2phecn37257e3f6y@hades.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190211162140.2phecn37257e3f6y@hades.usersys.redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Feb 11, 2019 at 05:21:40PM +0100, Carlos Maiolino wrote: > I'm more than happy in see your reply, I'd love to finish this, but I got stuck > in how to make some filesystems deny a FIBMAP call once they do support FIEMAP > but not FIBMAP. > > I have this patch almost ready to go anyway. Do you agree in keep this flag in > fi_flags field? Or maybe some other place, dunno, maybe a new fi_private field. Have it in fi_flags as a purely in-kernel flag, and then deny the bmap calls through fiemap based on it.