From: Matthew Wilcox <willy@infradead.org>
To: Dave Watson <davejwatson@fb.com>
Cc: "lsf-pc@lists.linux-foundation.org"
<lsf-pc@lists.linux-foundation.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Maged Michael <magedmichael@fb.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [LSF/MM TOPIC] Improve performance of fget/fput
Date: Fri, 15 Feb 2019 09:16:19 -0800 [thread overview]
Message-ID: <20190215171619.GI12668@bombadil.infradead.org> (raw)
In-Reply-To: <20190215163852.6ls6bchssazma6bm@davejwatson-mba.local>
On Fri, Feb 15, 2019 at 04:38:05PM +0000, Dave Watson wrote:
> There might also be ways to rearrange the file* struct or fd table so
> that we're not taking so many cache misses for sockfd_lookup_light,
> since for sockets we don't use most of the file* struct at all.
I don't think there's too much opportunity to rearrange the fd table.
We go from task_struct->files_struct->fdtable->fd[i]. I have a plan
to use the Maple Tree data structure I'm currently working on to change
that to task_struct->files_struct->maple_node->fd[i], but it'll be
the same number of cache misses.
prev parent reply other threads:[~2019-02-15 17:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 16:38 [LSF/MM TOPIC] Improve performance of fget/fput Dave Watson
2019-02-15 17:16 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190215171619.GI12668@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=davejwatson@fb.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lsf-pc@lists.linux-foundation.org \
--cc=magedmichael@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).