From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 524D7C43381 for ; Sat, 16 Feb 2019 15:15:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2165E222A3 for ; Sat, 16 Feb 2019 15:15:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728973AbfBPPPc (ORCPT ); Sat, 16 Feb 2019 10:15:32 -0500 Received: from hall.aurel32.net ([163.172.24.10]:54418 "EHLO hall.aurel32.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727151AbfBPPPb (ORCPT ); Sat, 16 Feb 2019 10:15:31 -0500 Received: from [2a01:e35:2e4c:a861:655e:aef3:f589:b897] (helo=ohm.rr44.fr) by hall.aurel32.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1gv1ge-0000Ps-PH; Sat, 16 Feb 2019 16:15:28 +0100 Received: from aurel32 by ohm.rr44.fr with local (Exim 4.92-RC5) (envelope-from ) id 1gv1ge-000752-3b; Sat, 16 Feb 2019 16:15:28 +0100 Date: Sat, 16 Feb 2019 16:15:28 +0100 From: Aurelien Jarno To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, x86@kernel.org, Alexander Viro , "H . J . Lu" Subject: Re: [PATCH] vfs: fix preadv64v2 and pwritev64v2 compat syscalls with offset == -1 Message-ID: <20190216151528.GA27079@aurel32.net> Mail-Followup-To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, x86@kernel.org, Alexander Viro , "H . J . Lu" References: <20181206190534.16246-1-aurelien@aurel32.net> <20190112190713.GA21480@aurel32.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190112190713.GA21480@aurel32.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 2019-01-12 20:07, Aurelien Jarno wrote: > On 2018-12-06 20:05, Aurelien Jarno wrote: > > The preadv2 and pwritev2 syscalls are supposed to emulate the readv and > > writev syscalls when offset == -1. Therefore the compat code should > > check for offset before calling do_compat_preadv64 and > > do_compat_pwritev64. This is the case for the preadv2 and pwritev2 > > syscalls, but handling of offset == -1 is missing in their 64-bit > > equivalent. > > > > This patch fixes that, calling do_compat_readv and do_compat_writev when > > offset == -1. This fixes the following glibc tests on x32: > > - misc/tst-preadvwritev2 > > - misc/tst-preadvwritev64v2 > > > > Cc: Alexander Viro > > Cc: H.J. Lu > > Signed-off-by: Aurelien Jarno > > --- > > fs/read_write.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > Any news about this patch? > Ping. Aurelien -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net