From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45365C43381 for ; Wed, 20 Feb 2019 16:20:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 081BB20880 for ; Wed, 20 Feb 2019 16:20:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="Kw/tJPZQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726174AbfBTQUY (ORCPT ); Wed, 20 Feb 2019 11:20:24 -0500 Received: from mail-yb1-f193.google.com ([209.85.219.193]:40765 "EHLO mail-yb1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725836AbfBTQUY (ORCPT ); Wed, 20 Feb 2019 11:20:24 -0500 Received: by mail-yb1-f193.google.com with SMTP id k2so5327593ybk.7 for ; Wed, 20 Feb 2019 08:20:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=C070tjgZJxeeM7qSOkI80GMDNtIZkLi+xqFiicAZtLg=; b=Kw/tJPZQVwsHlVFpahkttIFQss0Eipp5XPVuDSea8auNp+jXZgZaQInhaP5RWYuzjf gvUf9FmsQQ/fuztL1dblZUSAIUR9TgRJBm7m3zr51zMcEYfKKrZ10Hw9uP7YX43YmdLX C/AyIPk5gH9TKLYM0mpLa/RLhcU0aepE36Yg5IYCUy9wNLFJTt+XT/EOK6v1O29O5e8V G1kX9JR4zHR+7EMAHgfpnhYMsl/BIwPJjJtVp3gxZPiXiN5PSSof6zUKdXlU5ADVVxxc MEuwxE16uexTQU3v82WA6ZmU9pGBHLooUNGoDqBWwRzYFHYRN7IJjuPgtIXo4fubEPVD rJBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=C070tjgZJxeeM7qSOkI80GMDNtIZkLi+xqFiicAZtLg=; b=KVrkOOaBzaliWW88PS8d2QB59PEpLP8FLQEhZ72O/yI5wNg6rhfuQmHOuvyTHBzMYv L7ro/DVMZJlr0pQaIhrGCBnkTTKR7fr522EBjWS8Nq9lvTqyd8R10lXRAF1E5+lvdpoU ONEDJtFeQ2zXjEUf5jPd5vRoiKm3qENXId9k7Uyk2HsK+FRMkaMTne5zEOB1ekUoXtd9 hvMDlabLX8MfvpNL7KkLHzltVVUfyr2WckMnNasteI+9LHq2EGINKupeh54zb9xn9MLl DEvYZCQ7WjffT2g/drPQnqEoaSce0rVqbbvfn8mX3IvJQQwciUajKgqv+sqofAaACaZq T5+A== X-Gm-Message-State: AHQUAuazp69ogefdR8W9hS35ICg/y5CHa2VAeb8QEkJ+/VQn7+WH09tH DHlRsidZPLyjwqrKnrYClGh/zg== X-Google-Smtp-Source: AHgI3IZN1W/wbKuBXgVLSt798kyCnFIfqASvAzckD4HrIGMC9bsKeYF5LF5F7AKF7bKQac8nfIa2MA== X-Received: by 2002:a25:c887:: with SMTP id y129mr29225474ybf.398.1550679622984; Wed, 20 Feb 2019 08:20:22 -0800 (PST) Received: from localhost ([2620:10d:c091:200::7:9eba]) by smtp.gmail.com with ESMTPSA id x82sm39758ywd.11.2019.02.20.08.20.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Feb 2019 08:20:22 -0800 (PST) Date: Wed, 20 Feb 2019 11:20:21 -0500 From: Johannes Weiner To: Dave Chinner Cc: Roman Gushchin , "lsf-pc@lists.linux-foundation.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "riel@surriel.com" , "dchinner@redhat.com" , "guroan@gmail.com" , Kernel Team Subject: Re: [LSF/MM TOPIC] dying memory cgroups and slab reclaim issues Message-ID: <20190220162021.GB12866@cmpxchg.org> References: <20190219071329.GA7827@castle.DHCP.thefacebook.com> <20190220024723.GA20682@dastard> <20190220055031.GA23020@dastard> <20190220072707.GB23020@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190220072707.GB23020@dastard> User-Agent: Mutt/1.11.2 (2019-01-07) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Feb 20, 2019 at 06:27:07PM +1100, Dave Chinner wrote: > freeable = 1 > > ratio 4.15 priority 4.16 4.18 new > 1:100 1 12 0 batch 1 > 1.32 1 9 0 batch 1 > 1:12 1 6 0 batch 1 > 1:6 1 3 0 batch 1 > 1:1 1 1 1 batch 1 > @@ -479,7 +479,16 @@ static unsigned long do_shrink_slab(struct shrink_control *shrinkctl, > > total_scan = nr; > if (shrinker->seeks) { > - delta = freeable >> priority; > + /* > + * Use a small non-zero offset for delta so that if the scan > + * priority is low we always accumulate some pressure on caches > + * that have few freeable objects in them. This allows light > + * memory pressure to turn over caches with few freeable objects > + * slowly without the need for memory pressure priority to wind > + * up to the point where (freeable >> priority) is non-zero. > + */ > + delta = ilog2(freeable); The idea makes sense to me, but log2 fails us when freeable is 1. fls() should work, though. > + delta += freeable >> priority; > delta *= 4; > do_div(delta, shrinker->seeks); > } else {