From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CF34C43381 for ; Thu, 21 Feb 2019 22:46:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D381A207E0 for ; Thu, 21 Feb 2019 22:46:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=fb.com header.i=@fb.com header.b="IdKDj3yG"; dkim=pass (1024-bit key) header.d=fb.onmicrosoft.com header.i=@fb.onmicrosoft.com header.b="bT+crDcB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726693AbfBUWq5 (ORCPT ); Thu, 21 Feb 2019 17:46:57 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:43576 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725891AbfBUWq4 (ORCPT ); Thu, 21 Feb 2019 17:46:56 -0500 Received: from pps.filterd (m0148460.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x1LMYaKu013394; Thu, 21 Feb 2019 14:46:47 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=facebook; bh=oT+xA3GC6kP7R1nN3FaXPR31Q9urTPB1nHHEH1EnIV8=; b=IdKDj3yG8mt0+0XwSTL/enI4wetn5K21WvNfN1RXYFHsQDqyAN7V5gAg5kCRG4vPTD3E TNqLy6Oy8xFwFXdoG/2ccCJjlPSCAiRxw+SSiZQlK8cxj2XtqD8uJP9nq8FNxPL/UlDk 9Xdn3Et08UA9HenIcQOWgH5TeLDbBeXFd4c= Received: from maileast.thefacebook.com ([199.201.65.23]) by mx0a-00082601.pphosted.com with ESMTP id 2qt2bkrkar-7 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 21 Feb 2019 14:46:47 -0800 Received: from frc-hub02.TheFacebook.com (2620:10d:c021:18::172) by frc-hub06.TheFacebook.com (2620:10d:c021:18::176) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.1.1531.3; Thu, 21 Feb 2019 14:46:21 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (192.168.183.28) by o365-in.thefacebook.com (192.168.177.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.1.1531.3 via Frontend Transport; Thu, 21 Feb 2019 14:46:21 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.onmicrosoft.com; s=selector1-fb-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oT+xA3GC6kP7R1nN3FaXPR31Q9urTPB1nHHEH1EnIV8=; b=bT+crDcBV8JbAs2Vwg3Akah0KUW6PbYl3nyo+ISrO/l3NqKwmNsmNbQQrvzRuHLPyjeVSpi0pLJ+5KAL1TZpDB6E8XLqHuEp2wUlWsRYTo2s0Veii0qDpX0i1om//jQ3ncEaFZKnt/HCywVn/fLqsWnbund+md/BPXBtyW520fk= Received: from BYAPR15MB2631.namprd15.prod.outlook.com (20.179.156.24) by BYAPR15MB2599.namprd15.prod.outlook.com (20.179.155.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1622.20; Thu, 21 Feb 2019 22:46:20 +0000 Received: from BYAPR15MB2631.namprd15.prod.outlook.com ([fe80::ecc7:1a8c:289f:df92]) by BYAPR15MB2631.namprd15.prod.outlook.com ([fe80::ecc7:1a8c:289f:df92%3]) with mapi id 15.20.1643.016; Thu, 21 Feb 2019 22:46:20 +0000 From: Roman Gushchin To: Dave Chinner CC: "lsf-pc@lists.linux-foundation.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "riel@surriel.com" , "dchinner@redhat.com" , "guroan@gmail.com" , Kernel Team , "hannes@cmpxchg.org" Subject: Re: [LSF/MM TOPIC] dying memory cgroups and slab reclaim issues Thread-Topic: [LSF/MM TOPIC] dying memory cgroups and slab reclaim issues Thread-Index: AQHUyCKda3Qt+ClMVUers5iRNki+jqXn/PCAgAAzK4CAABr9gIACkyWA Date: Thu, 21 Feb 2019 22:46:19 +0000 Message-ID: <20190221224616.GB24252@tower.DHCP.thefacebook.com> References: <20190219071329.GA7827@castle.DHCP.thefacebook.com> <20190220024723.GA20682@dastard> <20190220055031.GA23020@dastard> <20190220072707.GB23020@dastard> In-Reply-To: <20190220072707.GB23020@dastard> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BYAPR01CA0060.prod.exchangelabs.com (2603:10b6:a03:94::37) To BYAPR15MB2631.namprd15.prod.outlook.com (2603:10b6:a03:152::24) x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [2620:10d:c090:200::6:b358] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2dc6c074-f0fa-46a4-b346-08d6984e6575 x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605104)(2017052603328)(7153060)(7193020);SRVR:BYAPR15MB2599; x-ms-traffictypediagnostic: BYAPR15MB2599: x-microsoft-exchange-diagnostics: 1;BYAPR15MB2599;20:pKJEt33BUVS9bIyGxbz7qu0lEZkLkxf/S8YuSKDEOdx3r4YXR+KTlQbs5UZr/P9fogX5UCJGOtJtup+IlODBpe2txYJWz/bH4MwOy5ddl+9Jf06iTzzGDiwiIpD7NPWO8Wn0oz/RuPwinmFRz+doyOGEuaSHThuLABRMI5DlMX0= x-microsoft-antispam-prvs: x-forefront-prvs: 09555FB1AD x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(346002)(376002)(366004)(136003)(39860400002)(396003)(189003)(199004)(97736004)(6246003)(86362001)(186003)(9686003)(102836004)(76176011)(229853002)(81156014)(8676002)(71200400001)(6512007)(106356001)(316002)(7736002)(52116002)(99286004)(6486002)(2906002)(305945005)(53936002)(8936002)(6436002)(33896004)(81166006)(71190400001)(25786009)(4744005)(33656002)(54906003)(386003)(446003)(93886005)(46003)(11346002)(14454004)(1076003)(6116002)(4326008)(6916009)(476003)(256004)(6506007)(486006)(105586002)(5660300002)(68736007)(478600001);DIR:OUT;SFP:1102;SCL:1;SRVR:BYAPR15MB2599;H:BYAPR15MB2631.namprd15.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: fb.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: AjMjlhevrMBIzdRhfyw5m8qCu9ubCXvobnqFRQZidjvtIjYhdwblPJmcE7qW4cHXqssCEDTqlAhMw5wXmrK1DGKsDIWDFjj6X5UP5Ny3tVtG5xCmswJYHlXLoqPcr7vkdIdCZ9xbbSTemQQArbTLEzhW+pF2HwcSUEkQn8689NyY0DLg05XEqrWpdiXRp1Tg84SHmirVHoXX1nKAJUBxkhqaNIVx/4sIN/+FABOhOKWBx5LpB8AFtpUZvZg1HYjIJi1JJcCBWeSm4hBsr25YYeMLmV78E+NVN9cud4hqYSOokAnG06zdywMXxu0w6AG3gzouigUnEH3cNx8Hlzd2QhC168kfNhjl4DTgg1WvvAX4YNBRwhywLIH7fnkWHgYGEG84i5aOjA965uGCqhxRq1rxHLgbEU8T4fRa4lmGRvk= Content-Type: text/plain; charset="us-ascii" Content-ID: <20451F9179FAF341ADFC9FE07EBE7BBE@namprd15.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 2dc6c074-f0fa-46a4-b346-08d6984e6575 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2019 22:46:19.1964 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB2599 X-OriginatorOrg: fb.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-02-21_14:,, signatures=0 X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Feb 20, 2019 at 06:27:07PM +1100, Dave Chinner wrote: > On Wed, Feb 20, 2019 at 04:50:31PM +1100, Dave Chinner wrote: > > I'm just going to fix the original regression in the shrinker > > algorithm by restoring the gradual accumulation behaviour, and this > > whole series of problems can be put to bed. >=20 > Something like this lightly smoke tested patch below. It may be > slightly more agressive than the original code for really small > freeable values (i.e. < 100) but otherwise should be roughly > equivalent to historic accumulation behaviour. >=20 > Cheers, >=20 > Dave. > --=20 > Dave Chinner > david@fromorbit.com >=20 > mm: fix shrinker scan accumulation regression >=20 > From: Dave Chinner JFYI: I'm testing this patch in our environment for fixing the memcg memory leak. It will take a couple of days to get reliable results. Thanks!