From: Matthew Wilcox <willy@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: Piotr Balcer <piotr.balcer@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org
Subject: Re: [PATCH] dax: Flush partial PMDs correctly
Date: Fri, 1 Mar 2019 11:13:52 -0800 [thread overview]
Message-ID: <20190301191352.GN11592@bombadil.infradead.org> (raw)
In-Reply-To: <20190301134954.GA31094@quack2.suse.cz>
On Fri, Mar 01, 2019 at 02:49:54PM +0100, Jan Kara wrote:
> > pfn = dax_to_pfn(entry);
> > - size = PAGE_SIZE << dax_entry_order(entry);
> > + count = 1UL << dax_entry_order(entry);
> > + index = xas->xa_index &~ (count - 1);
>
> Hum, why do you compute 'index' here when you actually never use it? The
> whole patch looks fishy since it is effectively a noop AFAICT...
*facepalm*. I lost the change to the next line while I was backing out
some extraneous changes.
> > dax_entry_mkclean(mapping, xas->xa_index, pfn);
Replacement patch sent.
next prev parent reply other threads:[~2019-03-01 19:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 4:24 [PATCH] dax: Flush partial PMDs correctly Matthew Wilcox
2019-03-01 13:49 ` Jan Kara
2019-03-01 19:13 ` Matthew Wilcox [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-03-01 19:12 Matthew Wilcox
2019-03-02 3:50 ` Dan Williams
2019-03-11 9:05 ` Jan Kara
2019-03-11 19:06 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190301191352.GN11592@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=dan.j.williams@intel.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=piotr.balcer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).