From: Al Viro <viro@zeniv.linux.org.uk>
To: Jann Horn <jannh@google.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] fs: use KERNEL_DS instead of get_ds()
Date: Sat, 2 Mar 2019 03:40:17 +0000 [thread overview]
Message-ID: <20190302034017.GM2217@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20190301200835.18286-1-jannh@google.com>
On Fri, Mar 01, 2019 at 09:08:35PM +0100, Jann Horn wrote:
> get_ds() is a legacy name for KERNEL_DS; all architectures #define it to
> KERNEL_DS,
not quite - h8300 and m68k have it as (equivalent) static inline.
> and almost every user of set_fs() uses the name KERNEL_DS.
>
> Let the VFS also use KERNEL_DS so that we can get rid of get_ds() at some
> point.
No objections, but that kind of stuff might be better done in a different
way: ask Linus to run this
git grep -n -w get_ds | tr ':' ' ' | while read file line junk; do
case "$file" in
*include*|tools*)
;;
*)
ed $file <<EOF
${line}s/get_ds()/KERNEL_DS/
w
q
EOF
;;
esac
done
just before -rc1, then follow it up with "kill unused get_ds()" patch
right after -rc1.
next prev parent reply other threads:[~2019-03-02 3:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 20:08 [PATCH] fs: use KERNEL_DS instead of get_ds() Jann Horn
2019-03-02 3:40 ` Al Viro [this message]
2019-03-05 0:23 ` Linus Torvalds
2019-03-08 14:01 ` Christoph Hellwig
2019-03-08 14:23 ` Al Viro
2019-03-08 16:20 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190302034017.GM2217@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=jannh@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).