From: Dominique Martinet <asmadeus@codewreck.org>
To: Hou Tao <houtao1@huawei.com>
Cc: v9fs-developer@lists.sourceforge.net, lucho@ionkov.net,
ericvh@gmail.com, linux-fsdevel@vger.kernel.org,
xingaopeng@huawei.com
Subject: Re: [PATCH v3 1/2] 9p: use inode->i_lock to protect i_size_write() under 32-bit
Date: Sun, 3 Mar 2019 05:57:08 +0100 [thread overview]
Message-ID: <20190303045708.GB15658@nautica> (raw)
In-Reply-To: <c55843e4-6d9d-3dd9-5c8b-11df15ed3ece@huawei.com>
Hou Tao wrote on Sat, Mar 02, 2019:
> I can not find the patch in your tree [1], so will the patch be landed in v5.1 ?
> Or are you expecting a v3 patch ?
Hmm right, sorry - I just didn't have much time for this and hoped I
could find time to sort the discussion we had on the second patch to
take both at once, but this definitely won't happen for 5.1 so I should
take the first patch for now. Will do that today after basic tests have
finished.
I should have taken it into -next earlier in principle but it can still
make it in 5.1, thanks for the reminder.
As for i_blocks, after some more thought and discussing off-list with
Jeff (Layton), I'm more or less decided that the best would be to make
this up straight from the size whenever size is updated.
"blocks" on a network FS does not really make sense to me but I
definitely want to avoid the case we have with i_blocks being 0
immediately after writing to a new file.
After your first patch I think the simplest thing to do would be to just
update i_blocks together with i_size in v9fs_i_size_write().
That's not a new bug however so I don't want to rush this in for 5.1
this late in the cycle so will take a more conservative approach on this
one, feel free to send a patch otherwise I will do once the next cycle
starts.
--
Dominique
next prev parent reply other threads:[~2019-03-03 4:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 6:35 [PATCH v3 0/2] use i_lock to protect updates of i_blocks & Hou Tao
2019-01-24 6:35 ` [PATCH v3 1/2] 9p: use inode->i_lock to protect i_size_write() under 32-bit Hou Tao
2019-01-24 6:57 ` Dominique Martinet
2019-01-24 11:01 ` Hou Tao
2019-03-02 11:31 ` Hou Tao
2019-03-03 4:57 ` Dominique Martinet [this message]
2019-01-24 6:35 ` [PATCH v3 2/2] 9p: use i_lock to protect update of inode->i_blocks " Hou Tao
2019-01-24 7:25 ` Dominique Martinet
2019-01-24 14:03 ` Hou Tao
2019-01-24 14:45 ` Dominique Martinet
2019-01-24 14:53 ` Dominique Martinet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190303045708.GB15658@nautica \
--to=asmadeus@codewreck.org \
--cc=ericvh@gmail.com \
--cc=houtao1@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=xingaopeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).