Linux filesystem development
 help / color / mirror / Atom feed
From: Al Viro <viro@zeniv.linux.org.uk>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [RFC] what's the point of register_filesystem() in drivers/dax/super.c?
Date: Sat, 16 Mar 2019 20:26:23 +0000	[thread overview]
Message-ID: <20190316202622.GE2217@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CAPcyv4jNdD6DcicoDkm9tYuWwVkY_Ri5FEotCPDmsE8=YAC6qA@mail.gmail.com>

On Sat, Mar 16, 2019 at 01:10:26PM -0700, Dan Williams wrote:
> On Sat, Mar 16, 2019 at 9:24 AM Al Viro <viro@zeniv.linux.org.uk> wrote:
> >
> >         It's not user-mountable, kern_mount() doesn't care about
> > looking it up by name, so the only effect of having it registered
> > is having it visible in /proc/filesystems.
> >
> >         Do you need that for anything?  Because I would rather
> > avoid more of that voodoo...
> 
> It can die. It was mindless copy/paste from fs/blockdev.c and the
> "bdev" fs. The device-dax unit tests pass just fine with it removed.
> I'll send a formal patch with the following:

Acked-by: Al Viro <viro@zeniv.linux.org.uk>

Do you prefer it in your tree, or would you rather have it go through
vfs.git?

  reply	other threads:[~2019-03-16 20:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-16 16:23 [RFC] what's the point of register_filesystem() in drivers/dax/super.c? Al Viro
2019-03-16 20:10 ` Dan Williams
2019-03-16 20:26   ` Al Viro [this message]
2019-03-17 17:56     ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190316202622.GE2217@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=dan.j.williams@intel.com \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox