From: Michal Hocko <mhocko@kernel.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: syzbot <syzbot+b70f2aabc707c69c9239@syzkaller.appspotmail.com>,
chanho.min@lge.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, pavel@ucw.cz,
rafael.j.wysocki@intel.com, syzkaller-bugs@googlegroups.com,
viro@zeniv.linux.org.uk, Ingo Molnar <mingo@elte.hu>
Subject: Re: WARNING: syz-executor still has locks held!
Date: Fri, 22 Mar 2019 11:36:54 +0100 [thread overview]
Message-ID: <20190322103654.GG32418@dhcp22.suse.cz> (raw)
In-Reply-To: <20190321172833.GB12297@redhat.com>
On Thu 21-03-19 18:28:33, Oleg Nesterov wrote:
> On 03/20, Michal Hocko wrote:
> >
> > So we need
> > freezable_schedule_unsafe unsafe here to workaround the original problem
> > and do not trigger the warning.
>
> Yes, but note the comment above freezable_schedule_unsafe() ;)
>
> that is why I didn't even try to suggest to use _unsafe() instead of reverting.
Maybe I have misunderstood the discussion back then but we _knew_ that
the lock is held and considered that an acceptable compromise to
workaround the issue. And that is where the freezable_schedule_unsafe
can be used AFAIU.
> And to remind, until we solve the problem with cred_guard_mutex the freezer
> can fail anyway although much less likely.
Sure but this seems much less likely as the original patch seemed to
resolve the failing suspend.
So unless there is something to really handle cred_guard_mutex now, can
we get back to the workaround and silence the lockdep splat and move on
please?
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2019-03-22 10:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-24 17:40 WARNING: syz-executor still has locks held! syzbot
2019-03-20 12:24 ` syzbot
2019-03-20 13:16 ` Michal Hocko
2019-03-20 13:24 ` Oleg Nesterov
2019-03-20 13:29 ` Michal Hocko
2019-03-20 15:00 ` Oleg Nesterov
2019-03-20 15:12 ` Michal Hocko
2019-03-20 17:30 ` Oleg Nesterov
2019-03-20 19:45 ` Michal Hocko
2019-03-20 20:32 ` Michal Hocko
2019-03-21 17:28 ` Oleg Nesterov
2019-03-22 10:36 ` Michal Hocko [this message]
2019-03-22 10:35 ` Pavel Machek
2019-03-20 13:18 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190322103654.GG32418@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=chanho.min@lge.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=pavel@ucw.cz \
--cc=rafael.j.wysocki@intel.com \
--cc=syzbot+b70f2aabc707c69c9239@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).