From: Bob Liu <bob.liu@oracle.com>
To: linux-block@vger.kernel.org
Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
martin.petersen@oracle.com, shirley.ma@oracle.com,
allison.henderson@oracle.com, david@fromorbit.com,
darrick.wong@oracle.com, hch@infradead.org, adilger@dilger.ca,
axboe@kernel.dk, tytso@mit.edu, Bob Liu <bob.liu@oracle.com>
Subject: [PATCH v3 3/3] fs: xfs: add read_verifier() function
Date: Fri, 29 Mar 2019 22:23:46 +0800 [thread overview]
Message-ID: <20190329142346.1677-4-bob.liu@oracle.com> (raw)
In-Reply-To: <20190329142346.1677-1-bob.liu@oracle.com>
This patch adds an new read_verifier function and pass to
the block layer to verify reads.
Signed-off-by: Bob Liu <bob.liu@oracle.com>
---
fs/xfs/xfs_buf.c | 23 +++++++++++++++++++++--
fs/xfs/xfs_buf.h | 1 +
2 files changed, 22 insertions(+), 2 deletions(-)
diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c
index 4f5f2ff3f70f..f3185dd9a557 100644
--- a/fs/xfs/xfs_buf.c
+++ b/fs/xfs/xfs_buf.c
@@ -1243,7 +1243,8 @@ xfs_buf_ioend(
xfs_buf_ioerror(bp, bp->b_io_error);
/* Only validate buffers that were read without errors */
- if (read && !bp->b_error && bp->b_ops) {
+ if (read && !bp->b_error && bp->b_ops &&
+ !(bp->b_flags & _XBF_NOVERIFY)) {
ASSERT(!bp->b_iodone);
bp->b_ops->verify_read(bp);
}
@@ -1343,6 +1344,24 @@ xfs_buf_bio_end_io(
bio_put(bio);
}
+int read_verifier(struct bio *bio)
+{
+ struct xfs_buf *bp = (struct xfs_buf *)bio->bi_private;
+
+ if (bp && !bp->b_error && bp->b_ops && bp->b_ops->verify_read) {
+ if (xfs_buf_is_vmapped(bp))
+ invalidate_kernel_vmap_range(bp->b_addr,
+ xfs_buf_vmap_len(bp));
+ bp->b_ops->verify_read(bp);
+ /* set bit so that endio won't verify it again */
+ if (!bp->b_error)
+ bp->b_flags |= _XBF_NOVERIFY;
+ return bp->b_error;
+ } else {
+ return 0;
+ }
+}
+
static void
xfs_buf_ioapply_map(
struct xfs_buf *bp,
@@ -1409,7 +1428,7 @@ xfs_buf_ioapply_map(
flush_kernel_vmap_range(bp->b_addr,
xfs_buf_vmap_len(bp));
}
- submit_bio(bio);
+ submit_bio_verify(bio, &read_verifier);
if (size)
goto next_chunk;
} else {
diff --git a/fs/xfs/xfs_buf.h b/fs/xfs/xfs_buf.h
index b9f5511ea998..499637c61001 100644
--- a/fs/xfs/xfs_buf.h
+++ b/fs/xfs/xfs_buf.h
@@ -50,6 +50,7 @@ typedef enum {
#define _XBF_KMEM (1 << 21)/* backed by heap memory */
#define _XBF_DELWRI_Q (1 << 22)/* buffer on a delwri queue */
#define _XBF_COMPOUND (1 << 23)/* compound buffer */
+#define _XBF_NOVERIFY (1 << 24)/* verify_read should not be called */
typedef unsigned int xfs_buf_flags_t;
--
2.17.1
prev parent reply other threads:[~2019-03-29 14:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 14:23 [RFC PATCH v3 0/3] Block/XFS: Support alternative mirror device retry Bob Liu
2019-03-29 14:23 ` [PATCH v3 1/3] block: introduce submit_bio_verify() Bob Liu
2019-03-29 22:22 ` Andreas Dilger
2019-03-30 1:43 ` Martin K. Petersen
2019-03-29 14:23 ` [PATCH v3 2/3] block: verify data when endio Bob Liu
2019-03-29 14:28 ` Jens Axboe
2019-03-29 14:34 ` Martin K. Petersen
2019-03-29 14:38 ` Jens Axboe
2019-03-29 14:46 ` Martin K. Petersen
2019-03-29 14:50 ` Jens Axboe
2019-03-29 14:51 ` Martin K. Petersen
2019-03-29 14:52 ` Jens Axboe
2019-03-29 15:00 ` Bob Liu
2019-03-29 15:03 ` Jens Axboe
2019-03-30 2:17 ` Martin K. Petersen
2019-03-31 22:00 ` Dave Chinner
2019-04-01 14:04 ` Martin K. Petersen
2019-04-01 21:21 ` Dave Chinner
2019-04-03 2:45 ` Martin K. Petersen
2019-04-03 22:21 ` Dave Chinner
2019-03-29 14:41 ` Bob Liu
2019-03-29 14:40 ` Bob Liu
2019-03-29 14:47 ` Jens Axboe
2019-03-30 0:20 ` Andreas Dilger
2019-03-29 15:39 ` Ming Lei
2019-03-29 14:23 ` Bob Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190329142346.1677-4-bob.liu@oracle.com \
--to=bob.liu@oracle.com \
--cc=adilger@dilger.ca \
--cc=allison.henderson@oracle.com \
--cc=axboe@kernel.dk \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=shirley.ma@oracle.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).