From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3405C43381 for ; Sat, 30 Mar 2019 00:15:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 60DC921773 for ; Sat, 30 Mar 2019 00:15:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=mbobrowski-org.20150623.gappssmtp.com header.i=@mbobrowski-org.20150623.gappssmtp.com header.b="rNnwUveu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730108AbfC3APS (ORCPT ); Fri, 29 Mar 2019 20:15:18 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:41763 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729963AbfC3APS (ORCPT ); Fri, 29 Mar 2019 20:15:18 -0400 Received: by mail-pg1-f194.google.com with SMTP id f6so1941395pgs.8 for ; Fri, 29 Mar 2019 17:15:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mbobrowski-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=8tMAxyJpNyvepj2pPOcRS+ggi153azO1J3evB3XHYWc=; b=rNnwUveu0N90S5iJOE2XRoxBCCx+3DnlgZkN1LTILOsU132SL3H22N0vSSnbnbz/nH VDsA7nIr4dbIibqEN1IX0wtvtYFyvl8mH7PQtjDEb3+KrCeJIla1mycqO4qbKmEZWomi VB+iAqpi3UjIC/myLiNKHzNM3mbw+X4TeJQh+wgb+7yOMeivBJB+OjA+81+6g9H4mQ2A DCYDEOqkFFDRteI+VaHkvzeHVofI60HLzHrCXeNRz/i9ugmtn34m7Q8YxqJzNAOJVvWu 2ZCamacn/lpfDru/j0eex5UdnlpRJi4m3O3l7YMrScn9DA5rHl08CmLBsxKompfRriU+ LiAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=8tMAxyJpNyvepj2pPOcRS+ggi153azO1J3evB3XHYWc=; b=dLE858i6zOe1Ea3ar6yYkaHwK28GapD4wZdgEbi0Mhd1JRjsj+toQ7qnPCrNOAEFrt Z9I/grC992174Lx+Ht40Goqsqva6LVDByjI4wNJdteVJKIhQgpSu0ogEUCfvXRjgDGSM jQFHg9a4yxXu8rVvzRkic6GEuHmeXz2oDosx89ET6dFIED+EG7kHz8AywExf+vQTyabs neNgP3R64JAceabiGPqok79PzwmHcWU3w0LfTyRaHC/+evZ7c6WxE+6ZC5it130Sl89t EIpPnenfw0vZe3Fl7f/R/8dx+fSJ//espvKQdyLfnR3ImQ+iOUT0sQ/HhgXIR5251xkC hFeg== X-Gm-Message-State: APjAAAXSPky0tb3CrwWOoFiq/Ns6gPl/9s32sWt5UR85h8yr5wqkL790 sWPcuovE7Vw8TZwkL4aH1POh X-Google-Smtp-Source: APXvYqy/bYzQ79lkPxv2W2tTNBRE4wEus+TrGBcBoKzgf5oSEh/MdEU8p++y7umzOqrj+rI0shVgUQ== X-Received: by 2002:a65:664d:: with SMTP id z13mr48031624pgv.389.1553904912005; Fri, 29 Mar 2019 17:15:12 -0700 (PDT) Received: from lithium.mbobrowski.org ([103.230.158.220]) by smtp.gmail.com with ESMTPSA id y19sm5155166pfn.164.2019.03.29.17.15.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 Mar 2019 17:15:11 -0700 (PDT) Date: Sat, 30 Mar 2019 11:15:04 +1100 From: Matthew Bobrowski To: Jan Kara Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org, linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, amir73il@gmail.com Subject: Re: [patch] fanotify.7, fanotify_init.2, fanotify_mark.2: Document FAN_REPORT_FID and directory modification events Message-ID: <20190330001502.GA26831@lithium.mbobrowski.org> References: <20190325005133.GA13990@lithium.mbobrowski.org> <20190329213730.GD8757@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190329213730.GD8757@quack2.suse.cz> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, Mar 29, 2019 at 10:37:30PM +0100, Jan Kara wrote: > On Mon 25-03-19 11:51:39, Matthew Bobrowski wrote: > > Details relating to the new initialization flag FAN_REPORT_FID has been > > added. As part of the FAN_REPORT_FID feature, a new set of event masks are > > available and have been documented accordingly. > > > > A simple example program has been added to also support the understanding > > and use case of FAN_REPORT_FID. > > > > Signed-off-by: Matthew Bobrowski > > Reviewed-by: Amir Goldstein > > Looks good to me, you can add: > > Reviewed-by: Jan Kara > > Two nits below: Thanks for the review Jan! Both nits have been addressed so I'll be sending through version 2 of this patch through at some point today. > > +.I hdr > > +This is a structure of type > > +.IR fanotify_event_info_header . > > +It is a generic header that contains information used to describe > > +additional information attached to the event. > > +For example, when an fanotify file descriptor is created using > > +.B FAN_REPORT_FID > > +the > > +.I info_type > > +field of this header is set to > > +.BR FAN_EVENT_INFO_TYPE_FID . > > +Event listeners can use this field to check that events of the correct > ^^^ additional > information of the correct type? > > ... I've changed it to the following which I believe is more accurate and is aligned with your recommendation. -- Event listeners can use this field to check that the additional information received for an event is of the correct type. -- -- Matthew Bobrowski