From: Christoph Hellwig <hch@infradead.org>
To: Qu Wenruo <wqu@suse.de>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] block: Add new BLK_STS_SELFTEST status
Date: Sun, 7 Apr 2019 23:32:35 -0700 [thread overview]
Message-ID: <20190408063235.GA1298@infradead.org> (raw)
In-Reply-To: <41acfcc7-1971-88a0-e34d-00fc34a5c190@suse.de>
On Sun, Apr 07, 2019 at 03:08:42PM +0800, Qu Wenruo wrote:
> > But then again I really wonder why you need to pass this information
> > through a blk_status_t to start with. In general these kinds of error
> > should be passed through file system specific errno fields.
> >
>
> For functions called in endio hook, we return blk_status_t.
> Or for case like hook before submitting bio, we set bio->bi_status to
> record it.
Ok. Good enough explanation, please add it to the changelog.
prev parent reply other threads:[~2019-04-08 6:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-06 10:37 [PATCH v2 1/2] block: Add new BLK_STS_SELFTEST status Qu Wenruo
2019-04-06 10:37 ` [PATCH v2 2/2] btrfs: Add error string for EUCLEAN Qu Wenruo
2019-04-07 7:04 ` [PATCH v2 1/2] block: Add new BLK_STS_SELFTEST status Christoph Hellwig
2019-04-07 7:08 ` Qu Wenruo
2019-04-08 6:32 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190408063235.GA1298@infradead.org \
--to=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=wqu@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).