From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 601B7C10F0E for ; Tue, 9 Apr 2019 23:13:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 344B820850 for ; Tue, 9 Apr 2019 23:13:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726794AbfDIXNB (ORCPT ); Tue, 9 Apr 2019 19:13:01 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:55128 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726592AbfDIXNB (ORCPT ); Tue, 9 Apr 2019 19:13:01 -0400 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92 #3 (Red Hat Linux)) id 1hDzvI-00012m-CJ; Tue, 09 Apr 2019 23:13:00 +0000 Date: Wed, 10 Apr 2019 00:13:00 +0100 From: Al Viro To: Murphy Zhou Cc: linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] fs/aio.c: fix wrong return value regression in __io_submit_one Message-ID: <20190409231300.GQ2217@ZenIV.linux.org.uk> References: <20190409060650.28901-1-jencce.kernel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190409060650.28901-1-jencce.kernel@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Apr 09, 2019 at 02:06:50PM +0800, Murphy Zhou wrote: > Now it returns 0 when actually error happened, causing kernel hang easily. > > Fixes: 7316b49 "aio: move sanity checks and request allocation to io_submit_one()" > Signed-off-by: Murphy Zhou See 18bfb9c6a8a5 (aio: Fix an error code in __io_submit_one()) in vfs.git#fixes...