From: Hans de Goede <hdegoede@redhat.com>
To: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Hans de Goede <hdegoede@redhat.com>,
David Howells <dhowells@redhat.com>,
linux-fsdevel@vger.kernel.org
Subject: [PATCH v10 0/1] fs: Add VirtualBox guest shared folder (vboxsf) support
Date: Thu, 18 Apr 2019 12:04:11 +0200 [thread overview]
Message-ID: <20190418100412.19016-1-hdegoede@redhat.com> (raw)
Hello Everyone,
Here is the 10th version of my cleaned-up / refactored version of the
VirtualBox shared-folder VFS driver.
This version hopefully addresses all issues pointed out in Al's detailed
review of v9 (thank you for the review Al):
Changes in v10:
-Code-style fixes and remove some unneeded checks as suggested by Al Viro
-Stop handle reuse between sf_create_aux and sf_reg_open, the code for this
was racy and the re-use meant the O_APPEND was not passed to the host for
newly created files with O_APPEND set
-Use idr to generate unique inode number, modelled after the kernfs code
-Only read and write the contents of the passed in offset pointer once in
sf_reg_write
-Keep a list of refcounted open handles in the inode, so that writepage can
get a writeable handle this way. This replaces the old very racy code which
was just storing a pointer to the last opened struct file inside the inode.
This is modelled after how the cifs and fuse code do this
For changes in older versions see the change log in the patch.
This version has been used by several distributions (arch, Fedora) for a
while now, so hopefully we can get this upstream soonish, please review.
Regards,
Hans
next reply other threads:[~2019-04-18 10:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 10:04 Hans de Goede [this message]
2019-04-18 10:04 ` [PATCH v10] fs: Add VirtualBox guest shared folder (vboxsf) support Hans de Goede
2019-05-28 13:55 ` David Howells
2019-06-05 8:50 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190418100412.19016-1-hdegoede@redhat.com \
--to=hdegoede@redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).