From: Matthew Wilcox <willy@infradead.org>
To: David Howells <dhowells@redhat.com>
Cc: viro@zeniv.linux.org.uk, Jan Harkes <jaharkes@cs.cmu.edu>,
coda@cs.cmu.edu, codalist@coda.cs.cmu.edu,
linux-afs@lists.infradead.org, linux-ext4@vger.kernel.org,
linux-ntfs-dev@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/6] vfs, coda: Fix the lack of locking in FID replacement inode rehashing
Date: Thu, 18 Apr 2019 09:10:24 -0700 [thread overview]
Message-ID: <20190418161024.GG7751@bombadil.infradead.org> (raw)
In-Reply-To: <155559636704.21702.4538723150377303298.stgit@warthog.procyon.org.uk>
On Thu, Apr 18, 2019 at 03:06:07PM +0100, David Howells wrote:
> Fix this by moving the core part of the code to fs/inode.c and providing it
> with a set() function akin to iget5(). We can then take the inode cache
> lock whilst performing the move.
> @@ -123,6 +132,8 @@ void coda_replace_fid(struct inode *inode, struct CodaFid *oldfid,
>
> BUG_ON(!coda_fideq(&cii->c_fid, oldfid));
>
> + rehash_inode(inode, hash, coda_reset_inode, newfid);
> +
> /* replace fid and rehash inode */
> /* XXX we probably need to hold some lock here! */
> remove_inode_hash(inode);
Don't you also need to delete the remove_inode_hash() and
__insert_inode_hash() calls?
next prev parent reply other threads:[~2019-04-18 16:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 14:05 [RFC PATCH 0/6] vfs: Make icache searchable under RCU David Howells
2019-04-18 14:06 ` [RFC PATCH 1/6] vfs, coda: Fix the lack of locking in FID replacement inode rehashing David Howells
2019-04-18 14:48 ` Jan Harkes
2019-04-18 16:10 ` Matthew Wilcox [this message]
2019-04-18 16:12 ` David Howells
2019-04-18 14:06 ` [RFC PATCH 2/6] vfs: Change inode_hash_lock to a seqlock David Howells
2019-04-18 14:06 ` [RFC PATCH 3/6] vfs: Allow searching of the icache under RCU conditions David Howells
2019-04-18 14:06 ` [RFC PATCH 4/6] afs: Use RCU inode cache search for callback resolution David Howells
2019-04-18 14:06 ` [RFC PATCH 5/6] ext4: Search for an inode to update under the RCU lock if we can David Howells
2019-04-18 15:08 ` Al Viro
2019-04-18 14:06 ` [RFC PATCH 6/6] vfs: Delete find_inode_nowait() David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190418161024.GG7751@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=coda@cs.cmu.edu \
--cc=codalist@coda.cs.cmu.edu \
--cc=dhowells@redhat.com \
--cc=jaharkes@cs.cmu.edu \
--cc=linux-afs@lists.infradead.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntfs-dev@lists.sourceforge.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).