From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 213D2C282DF for ; Thu, 18 Apr 2019 18:42:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E0B18217D7 for ; Thu, 18 Apr 2019 18:42:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555612979; bh=Qj/E+Qtg7ETHxq3VGlR9bxwhjV0lRU14opKqg7rPS9c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=v/TqIlpesay5JkQ7uirYuP20ef629TDkRYDgSolldtZPSjkfukiKZbTSRiORY2kTM Eyx36gR5p7KqpmJQAK1GNu0zYJ+FscNH0mtYHHHkqGVPGrBs80ts3wqXu66BFYIhFL WQabCbPUVKF52MR5WRy6hTKSNX3YoniAgTLLyd+0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390009AbfDRSm6 (ORCPT ); Thu, 18 Apr 2019 14:42:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:60792 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390006AbfDRSm5 (ORCPT ); Thu, 18 Apr 2019 14:42:57 -0400 Received: from localhost.localdomain (unknown [24.213.116.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B39D6217D7; Thu, 18 Apr 2019 18:42:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555612977; bh=Qj/E+Qtg7ETHxq3VGlR9bxwhjV0lRU14opKqg7rPS9c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fM75RZbzqOu5hxXrtr7HsTogX7YQydLVa3HYQ3/4MVbZA7Wb1iKzy+wJxb1BKtSn1 iZo8TCL12WZRl2PD0/CfwLloV6mS49UlIrkEUdH0ryBz6LlDOX7gTQsId0C2fz84aN dhfGUqix6/CIn+ham0G32IzwKwfF6mfBVTUlB9Kc= From: hubcap@kernel.org To: linux-fsdevel@vger.kernel.org, christoph@lameter.com Cc: Martin Brandenburg , Mike Marshall Subject: [PATCH 15/22] orangefs: skip inode writeout if nothing to write Date: Thu, 18 Apr 2019 14:41:07 -0400 Message-Id: <20190418184113.9152-16-hubcap@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190418184113.9152-1-hubcap@kernel.org> References: <20190418184113.9152-1-hubcap@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org From: Martin Brandenburg Would happen if an inode is dirty but whatever happened is not something that can be written out to OrangeFS. Signed-off-by: Martin Brandenburg Signed-off-by: Mike Marshall --- fs/orangefs/orangefs-utils.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/fs/orangefs/orangefs-utils.c b/fs/orangefs/orangefs-utils.c index d6093a468db9..d4b7ae763186 100644 --- a/fs/orangefs/orangefs-utils.c +++ b/fs/orangefs/orangefs-utils.c @@ -431,6 +431,11 @@ int orangefs_inode_setattr(struct inode *inode) copy_attributes_from_inode(inode, &new_op->upcall.req.setattr.attributes); orangefs_inode->attr_valid = 0; + if (!new_op->upcall.req.setattr.attributes.mask) { + spin_unlock(&inode->i_lock); + op_release(new_op); + return 0; + } spin_unlock(&inode->i_lock); ret = service_operation(new_op, __func__, -- 2.20.1