* Re: [PATCH] block/028: check if T10 verification fails [not found] ` <20190426145711.GA12338@infradead.org> @ 2019-04-26 22:16 ` Ming Lei 2019-04-27 1:24 ` Darrick J. Wong 0 siblings, 1 reply; 3+ messages in thread From: Ming Lei @ 2019-04-26 22:16 UTC (permalink / raw) To: Christoph Hellwig, Alexander Viro, linux-fsdevel Cc: Omar Sandoval, linux-block, Martin K . Petersen On Fri, Apr 26, 2019 at 07:57:11AM -0700, Christoph Hellwig wrote: > On Fri, Apr 26, 2019 at 10:39:37AM +0800, Ming Lei wrote: > > When T10 verification fails, the error code of BLK_STS_PROTECTION > > may not be propagated to user space, see mpage_end_io(). > > Well, we should probably fix that instead of papering over it.. That might be a big change, and not sure when they can be fixed completely. This patch at least can expose the issue to user first. Anyway, CC filesystem guys. Thanks, Ming ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] block/028: check if T10 verification fails 2019-04-26 22:16 ` [PATCH] block/028: check if T10 verification fails Ming Lei @ 2019-04-27 1:24 ` Darrick J. Wong 2019-04-27 3:29 ` Ming Lei 0 siblings, 1 reply; 3+ messages in thread From: Darrick J. Wong @ 2019-04-27 1:24 UTC (permalink / raw) To: Ming Lei Cc: Christoph Hellwig, Alexander Viro, linux-fsdevel, Omar Sandoval, linux-block, Martin K . Petersen On Sat, Apr 27, 2019 at 06:16:32AM +0800, Ming Lei wrote: > On Fri, Apr 26, 2019 at 07:57:11AM -0700, Christoph Hellwig wrote: > > On Fri, Apr 26, 2019 at 10:39:37AM +0800, Ming Lei wrote: > > > When T10 verification fails, the error code of BLK_STS_PROTECTION > > > may not be propagated to user space, see mpage_end_io(). > > > > Well, we should probably fix that instead of papering over it.. > > That might be a big change, and not sure when they can be fixed > completely. > > This patch at least can expose the issue to user first. I don't see a patch anywhere ... ? --D > Anyway, CC filesystem guys. > > Thanks, > Ming ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] block/028: check if T10 verification fails 2019-04-27 1:24 ` Darrick J. Wong @ 2019-04-27 3:29 ` Ming Lei 0 siblings, 0 replies; 3+ messages in thread From: Ming Lei @ 2019-04-27 3:29 UTC (permalink / raw) To: Darrick J. Wong Cc: Christoph Hellwig, Alexander Viro, linux-fsdevel, Omar Sandoval, linux-block, Martin K . Petersen On Fri, Apr 26, 2019 at 06:24:49PM -0700, Darrick J. Wong wrote: > On Sat, Apr 27, 2019 at 06:16:32AM +0800, Ming Lei wrote: > > On Fri, Apr 26, 2019 at 07:57:11AM -0700, Christoph Hellwig wrote: > > > On Fri, Apr 26, 2019 at 10:39:37AM +0800, Ming Lei wrote: > > > > When T10 verification fails, the error code of BLK_STS_PROTECTION > > > > may not be propagated to user space, see mpage_end_io(). > > > > > > Well, we should probably fix that instead of papering over it.. > > > > That might be a big change, and not sure when they can be fixed > > completely. > > > > This patch at least can expose the issue to user first. > > I don't see a patch anywhere ... ? It is one blktest patch, please see the following link: https://lore.kernel.org/linux-block/20190427012449.GC178347@magnolia/T/#t Thanks, Ming ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-27 3:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190426023937.19584-1-ming.lei@redhat.com>
[not found] ` <20190426145711.GA12338@infradead.org>
2019-04-26 22:16 ` [PATCH] block/028: check if T10 verification fails Ming Lei
2019-04-27 1:24 ` Darrick J. Wong
2019-04-27 3:29 ` Ming Lei
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).