From: Miklos Szeredi <miklos@szeredi.hu>
To: Steve French <smfrench@gmail.com>
Cc: Jan Kara <jack@suse.cz>, Amir Goldstein <amir73il@gmail.com>,
linux-fsdevel@vger.kernel.org
Subject: [RFC PATCH] network fs notification
Date: Wed, 1 May 2019 16:55:41 -0400 [thread overview]
Message-ID: <20190501205541.GC30899@veci.piliscsaba.redhat.com> (raw)
This is a really really trivial first iteration, but I think it's enough to
try out CIFS notification support. Doesn't deal with mark deletion, but
that's best effort anyway: fsnotify() will filter out unneeded events.
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
---
fs/notify/fanotify/fanotify_user.c | 6 +++++-
fs/notify/inotify/inotify_user.c | 2 ++
include/linux/fs.h | 1 +
3 files changed, 8 insertions(+), 1 deletion(-)
--- a/fs/notify/fanotify/fanotify_user.c
+++ b/fs/notify/fanotify/fanotify_user.c
@@ -1041,9 +1041,13 @@ static int do_fanotify_mark(int fanotify
else if (mark_type == FAN_MARK_FILESYSTEM)
ret = fanotify_add_sb_mark(group, mnt->mnt_sb, mask,
flags, fsid);
- else
+ else {
ret = fanotify_add_inode_mark(group, inode, mask,
flags, fsid);
+
+ if (!ret && inode->i_op->notify_update)
+ inode->i_op->notify_update(inode);
+ }
break;
case FAN_MARK_REMOVE:
if (mark_type == FAN_MARK_MOUNT)
--- a/fs/notify/inotify/inotify_user.c
+++ b/fs/notify/inotify/inotify_user.c
@@ -754,6 +754,8 @@ SYSCALL_DEFINE3(inotify_add_watch, int,
/* create/update an inode mark */
ret = inotify_update_watch(group, inode, mask);
+ if (!ret && inode->i_op->notify_update)
+ inode->i_op->notify_update(inode);
path_put(&path);
fput_and_out:
fdput(f);
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -1852,6 +1852,7 @@ struct inode_operations {
umode_t create_mode);
int (*tmpfile) (struct inode *, struct dentry *, umode_t);
int (*set_acl)(struct inode *, struct posix_acl *, int);
+ void (*notify_update)(struct inode *inode);
} ____cacheline_aligned;
static inline ssize_t call_read_iter(struct file *file, struct kiocb *kio,
next reply other threads:[~2019-05-01 20:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 20:55 Miklos Szeredi [this message]
2019-05-02 14:39 ` [RFC PATCH] network fs notification Jan Kara
2019-05-02 15:08 ` Amir Goldstein
2019-05-02 15:41 ` Jan Kara
2019-05-02 17:22 ` Miklos Szeredi
2019-05-07 8:57 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190501205541.GC30899@veci.piliscsaba.redhat.com \
--to=miklos@szeredi.hu \
--cc=amir73il@gmail.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox