From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7C53C43219 for ; Wed, 1 May 2019 22:05:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 773472085A for ; Wed, 1 May 2019 22:05:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726173AbfEAWFS (ORCPT ); Wed, 1 May 2019 18:05:18 -0400 Received: from mail104.syd.optusnet.com.au ([211.29.132.246]:43531 "EHLO mail104.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726137AbfEAWFS (ORCPT ); Wed, 1 May 2019 18:05:18 -0400 Received: from dread.disaster.area (pa49-181-171-240.pa.nsw.optusnet.com.au [49.181.171.240]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id E77EE43A258; Thu, 2 May 2019 08:05:15 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92) (envelope-from ) id 1hLxLn-0004sX-4k; Thu, 02 May 2019 08:05:15 +1000 Date: Thu, 2 May 2019 08:05:15 +1000 From: Dave Chinner To: Christoph Hellwig Cc: darrick.wong@oracle.com, agruenba@redhat.com, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] iomap: move iomap_read_inline_data around Message-ID: <20190501220515.GM1454@dread.disaster.area> References: <20190501161111.32475-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190501161111.32475-1-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.2 cv=UJetJGXy c=1 sm=1 tr=0 cx=a_idp_d a=LhzQONXuMOhFZtk4TmSJIw==:117 a=LhzQONXuMOhFZtk4TmSJIw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=E5NmQfObTbMA:10 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=JuDxSlhT3OO6blO4plAA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, May 01, 2019 at 12:11:11PM -0400, Christoph Hellwig wrote: > iomap_read_inline_data ended up being placed in the middle of the bio > based read I/O completion handling, which tends to confuse the heck out > of me whenever I follow the code. Move it to a more suitable place. > > Signed-off-by: Christoph Hellwig Makes sense. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com