From: Matthew Wilcox <willy@infradead.org>
To: Tamir Carmeli <carmeli.tamir@gmail.com>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Use list.h instead of file_system_type next
Date: Sun, 5 May 2019 19:49:58 -0700 [thread overview]
Message-ID: <20190506024958.GC16963@bombadil.infradead.org> (raw)
In-Reply-To: <CAKxm1-H9cgym_RQ-oLcZWEPpyUf5NrZPt_Zu3U=mpU=E38SbvQ@mail.gmail.com>
On Sun, May 05, 2019 at 09:25:21PM +0300, Tamir Carmeli wrote:
> I just found it weird that there is a proprietary implementation of a
> linked list while surely the kernel already offers well established
> data structures.
It's a singly linked list rather than a doubly linked list.
> IMO, the current code is a bit hard to understand, especially the
> addition of a new struct to the list in the line "*p = fs" after
> find_filesystem returned the last member.
> Correct, I'm not familiar with all the use cases of the code.
It looks like a fairly standard implementation of a singly-linked
list in C to me.
> I'm not sure that XArray is a good choice since there is no notion of
> an index attached to the pointer, it's really just a linked list of
> pointers.
You don't need to attach an index to the pointer; you can just use
xa_alloc() to store it at the first available index.
next prev parent reply other threads:[~2019-05-06 2:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-04 9:45 [PATCH 0/2] Refactor file_systems to use the kernel's list Carmeli Tamir
2019-05-04 9:45 ` [PATCH 1/2] Use list.h instead of file_system_type next Carmeli Tamir
2019-05-04 13:20 ` Al Viro
2019-05-04 13:45 ` Matthew Wilcox
2019-05-05 18:25 ` Tamir Carmeli
2019-05-06 2:49 ` Matthew Wilcox [this message]
2019-05-06 15:16 ` kbuild test robot
2019-05-06 17:33 ` kbuild test robot
2019-05-04 9:45 ` [PATCH 2/2] Changed unsigned param type to unsigned int Carmeli Tamir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190506024958.GC16963@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=carmeli.tamir@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).