From: Kees Cook <keescook@chromium.org>
To: Weitao Hou <houweitaoo@gmail.com>
Cc: mcgrof@kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2] kernel: fix typos and some coding style in comments
Date: Mon, 20 May 2019 08:42:05 -0700 [thread overview]
Message-ID: <201905200841.8A35A0C@keescook> (raw)
In-Reply-To: <20190520023700.8472-1-houweitaoo@gmail.com>
On Mon, May 20, 2019 at 10:37:00AM +0800, Weitao Hou wrote:
> fix lenght to length
What about the other instances of this misspelling? (See "git grep
lenght").
-Kees
>
> Signed-off-by: Weitao Hou <houweitaoo@gmail.com>
> ---
> Changes in v2:
> - fix space before tab warnings
> ---
> kernel/sysctl.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/kernel/sysctl.c b/kernel/sysctl.c
> index 943c89178e3d..f78f725f225e 100644
> --- a/kernel/sysctl.c
> +++ b/kernel/sysctl.c
> @@ -187,17 +187,17 @@ extern int no_unaligned_warning;
> * enum sysctl_writes_mode - supported sysctl write modes
> *
> * @SYSCTL_WRITES_LEGACY: each write syscall must fully contain the sysctl value
> - * to be written, and multiple writes on the same sysctl file descriptor
> - * will rewrite the sysctl value, regardless of file position. No warning
> - * is issued when the initial position is not 0.
> + * to be written, and multiple writes on the same sysctl file descriptor
> + * will rewrite the sysctl value, regardless of file position. No warning
> + * is issued when the initial position is not 0.
> * @SYSCTL_WRITES_WARN: same as above but warn when the initial file position is
> - * not 0.
> + * not 0.
> * @SYSCTL_WRITES_STRICT: writes to numeric sysctl entries must always be at
> - * file position 0 and the value must be fully contained in the buffer
> - * sent to the write syscall. If dealing with strings respect the file
> - * position, but restrict this to the max length of the buffer, anything
> - * passed the max lenght will be ignored. Multiple writes will append
> - * to the buffer.
> + * file position 0 and the value must be fully contained in the buffer
> + * sent to the write syscall. If dealing with strings respect the file
> + * position, but restrict this to the max length of the buffer, anything
> + * passed the max length will be ignored. Multiple writes will append
> + * to the buffer.
> *
> * These write modes control how current file position affects the behavior of
> * updating sysctl values through the proc interface on each write.
> --
> 2.18.0
>
--
Kees Cook
prev parent reply other threads:[~2019-05-20 15:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 2:37 [PATCH v2] kernel: fix typos and some coding style in comments Weitao Hou
2019-05-20 15:42 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201905200841.8A35A0C@keescook \
--to=keescook@chromium.org \
--cc=houweitaoo@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).