From: Dan Carpenter <dan.carpenter@oracle.com>
To: axboe@kernel.dk
Cc: linux-fsdevel@vger.kernel.org
Subject: [bug report] io_uring: add support for sqe links
Date: Mon, 27 May 2019 13:08:08 +0300 [thread overview]
Message-ID: <20190527100808.GA31410@mwanda> (raw)
Hello Jens Axboe,
The patch f3fafe4103bd: "io_uring: add support for sqe links" from
May 10, 2019, leads to the following static checker warning:
fs/io_uring.c:623 io_req_link_next()
error: potential NULL dereference 'nxt'.
fs/io_uring.c
614 static void io_req_link_next(struct io_kiocb *req)
615 {
616 struct io_kiocb *nxt;
617
618 nxt = list_first_entry_or_null(&req->link_list, struct io_kiocb, list);
619 list_del(&nxt->list);
^^^^^^^^^
The warning is a false positive but this is a NULL dereference.
620 if (!list_empty(&req->link_list)) {
621 INIT_LIST_HEAD(&nxt->link_list);
^^^^^
False positive.
622 list_splice(&req->link_list, &nxt->link_list);
623 nxt->flags |= REQ_F_LINK;
624 }
625
626 INIT_WORK(&nxt->work, io_sq_wq_submit_work);
^^^^^^^^^^
627 queue_work(req->ctx->sqo_wq, &nxt->work);
^^^^^^^^^^
Other bugs.
628 }
regards,
dan carpenter
next reply other threads:[~2019-05-27 10:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-27 10:08 Dan Carpenter [this message]
2019-05-27 13:36 ` [bug report] io_uring: add support for sqe links Jens Axboe
2019-05-27 14:10 ` Dan Carpenter
2019-05-27 14:34 ` Jens Axboe
2019-05-27 15:23 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190527100808.GA31410@mwanda \
--to=dan.carpenter@oracle.com \
--cc=axboe@kernel.dk \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).