* [PATCH] fs/direct-io.c: include fs/internal.h for missing prototype
@ 2019-05-29 21:21 Eric Biggers
0 siblings, 0 replies; 3+ messages in thread
From: Eric Biggers @ 2019-05-29 21:21 UTC (permalink / raw)
To: linux-fsdevel, Alexander Viro
From: Eric Biggers <ebiggers@google.com>
Include fs/internal.h to address the following 'sparse' warning:
fs/direct-io.c:622:5: warning: symbol 'sb_init_dio_done_wq' was not declared. Should it be static?
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
fs/direct-io.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/direct-io.c b/fs/direct-io.c
index ac7fb19b6ade5..601b402829239 100644
--- a/fs/direct-io.c
+++ b/fs/direct-io.c
@@ -39,6 +39,8 @@
#include <linux/atomic.h>
#include <linux/prefetch.h>
+#include "internal.h"
+
/*
* How many user pages to map in one call to get_user_pages(). This determines
* the size of a structure in the slab cache
--
2.22.0.rc1.257.g3120a18244-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] fs/direct-io.c: include fs/internal.h for missing prototype
@ 2019-12-09 23:45 Eric Biggers
2019-12-13 10:40 ` Jan Kara
0 siblings, 1 reply; 3+ messages in thread
From: Eric Biggers @ 2019-12-09 23:45 UTC (permalink / raw)
To: Andrew Morton; +Cc: Alexander Viro, linux-fsdevel
From: Eric Biggers <ebiggers@google.com>
Include fs/internal.h to address the following 'sparse' warning:
fs/direct-io.c:591:5: warning: symbol 'sb_init_dio_done_wq' was not declared. Should it be static?
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
Hi Andrew, please consider applying this straightforward cleanup.
This has been sent to Al four times with no response.
fs/direct-io.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/direct-io.c b/fs/direct-io.c
index 0ec4f270139f6..00b4d15bb811a 100644
--- a/fs/direct-io.c
+++ b/fs/direct-io.c
@@ -39,6 +39,8 @@
#include <linux/atomic.h>
#include <linux/prefetch.h>
+#include "internal.h"
+
/*
* How many user pages to map in one call to get_user_pages(). This determines
* the size of a structure in the slab cache
--
2.24.0.393.g34dc348eaf-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fs/direct-io.c: include fs/internal.h for missing prototype
2019-12-09 23:45 Eric Biggers
@ 2019-12-13 10:40 ` Jan Kara
0 siblings, 0 replies; 3+ messages in thread
From: Jan Kara @ 2019-12-13 10:40 UTC (permalink / raw)
To: Eric Biggers; +Cc: Andrew Morton, Alexander Viro, linux-fsdevel
On Mon 09-12-19 15:45:44, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Include fs/internal.h to address the following 'sparse' warning:
>
> fs/direct-io.c:591:5: warning: symbol 'sb_init_dio_done_wq' was not declared. Should it be static?
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Makes sense. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
>
> Hi Andrew, please consider applying this straightforward cleanup.
> This has been sent to Al four times with no response.
>
> fs/direct-io.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/direct-io.c b/fs/direct-io.c
> index 0ec4f270139f6..00b4d15bb811a 100644
> --- a/fs/direct-io.c
> +++ b/fs/direct-io.c
> @@ -39,6 +39,8 @@
> #include <linux/atomic.h>
> #include <linux/prefetch.h>
>
> +#include "internal.h"
> +
> /*
> * How many user pages to map in one call to get_user_pages(). This determines
> * the size of a structure in the slab cache
> --
> 2.24.0.393.g34dc348eaf-goog
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-13 10:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-29 21:21 [PATCH] fs/direct-io.c: include fs/internal.h for missing prototype Eric Biggers
-- strict thread matches above, loose matches on Subject: below --
2019-12-09 23:45 Eric Biggers
2019-12-13 10:40 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).