From: Al Viro <viro@zeniv.linux.org.uk>
To: Aurelien Thierry <aurelien.thierry@quoscient.io>
Cc: linux-fsdevel@vger.kernel.org, trivial@kernel.org
Subject: Re: [PATCH] fs: relatime update - Match comment with behavior
Date: Tue, 18 Jun 2019 02:12:16 +0100 [thread overview]
Message-ID: <20190618011216.GY17978@ZenIV.linux.org.uk> (raw)
In-Reply-To: <5553a3e1-bc49-4553-0648-91350be3ae9c@quoscient.io>
On Tue, Jun 11, 2019 at 07:45:40AM +0200, Aurelien Thierry wrote:
> 2 comments right before code wrongly state that if (c|m)time is younger
> than atime, then atime is updated (behavior is the other way around).
>
> Fix aligns comments with actual behavior, function description and
> documentation (man mount).
Huh? "mtime is younger than atime" means that mtime refers to the moment
later than that refered to by atime, i.e that atime refers to the moment
earlier than that refered to by mtime. What is the problem you are trying
to fix?
Both the original and changed comments mean exact same thing. And yes,
the changed comment does match the actual behaviour. Just as the original
one does...
next prev parent reply other threads:[~2019-06-18 1:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 5:45 [PATCH] fs: relatime update - Match comment with behavior Aurelien Thierry
2019-06-18 1:12 ` Al Viro [this message]
2019-06-18 11:43 ` Aurelien Thierry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618011216.GY17978@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=aurelien.thierry@quoscient.io \
--cc=linux-fsdevel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).