From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: * X-Spam-Status: No, score=1.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_MUTT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57494C31E5E for ; Tue, 18 Jun 2019 16:58:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2744D20B1F for ; Tue, 18 Jun 2019 16:58:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560877134; bh=3vKBeAv0ShrIxat0BRxsGm3sPQZrnnaIEz4l4EoSWqQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=qRuGtnoarcwNLbpgxsW7r7xb/aJsl7Py9I210taL0eXWGXo6k+t8nld+08UtarPIW AQj+KOfn7bwAhElHFRJ2gS/oF/nsnEq95n93pcyYS9K7yTz0kWujHH9nWSLbSWY/aq 9WzyTaswGD6sXX0mETsw2gcd5FHJv9gnkgIBYXxQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729914AbfFRQ6x (ORCPT ); Tue, 18 Jun 2019 12:58:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:44044 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729472AbfFRQ6w (ORCPT ); Tue, 18 Jun 2019 12:58:52 -0400 Received: from gmail.com (unknown [104.132.1.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5F52B206E0; Tue, 18 Jun 2019 16:58:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560877131; bh=3vKBeAv0ShrIxat0BRxsGm3sPQZrnnaIEz4l4EoSWqQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LE7EIq6eA2PpxpOB1likILRe0O8eGxX/GDvOgCYGT38/kRS9NlSM1Kuz5tGlTlTm0 wnaCikRm2uhxP3Pv2kbqMbs6aaqTTjd2hbYAt5k4w08SaLKVg8D7DsKU3aBQjBmY56 Inj4c3YclM86a8bTlmUILWCHPZboeq+XH8FsmLDM= Date: Tue, 18 Jun 2019 09:58:49 -0700 From: Eric Biggers To: Theodore Ts'o Cc: linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-integrity@vger.kernel.org, Victor Hsieh , Jaegeuk Kim , Dave Chinner , Christoph Hellwig , "Darrick J . Wong" , Linus Torvalds Subject: Re: [PATCH v4 13/16] fs-verity: support builtin file signatures Message-ID: <20190618165849.GE184520@gmail.com> References: <20190606155205.2872-1-ebiggers@kernel.org> <20190606155205.2872-14-ebiggers@kernel.org> <20190615152143.GN6142@mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190615152143.GN6142@mit.edu> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Sat, Jun 15, 2019 at 11:21:43AM -0400, Theodore Ts'o wrote: > On Thu, Jun 06, 2019 at 08:52:02AM -0700, Eric Biggers wrote: > > From: Eric Biggers > > > > To meet some users' needs, add optional support for having fs-verity > > handle a portion of the authentication policy in the kernel. An > > ".fs-verity" keyring is created to which X.509 certificates can be > > added; then a sysctl 'fs.verity.require_signatures' can be set to cause > > the kernel to enforce that all fs-verity files contain a signature of > > their file measurement by a key in this keyring. > > I think it might be a good idea to allow the require_signatures > setting to be set on a per-file system basis, via a mount option? We > could plumb it in via a flag in fsverity_info, set by the file system. Perhaps, but this is something that can be added later, so I think we should hold off on it until someone needs it. > > Other than this feature request, looks good; you can add: > > Reviewed-off-by: Theodore Ts'o > I assume you mean "Reviewed-by" :-) - Eric